Page MenuHomeFreeBSD

Remove redeclaration found by gcc build
ClosedPublic

Authored by lwhsu on Aug 5 2020, 5:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 2:03 AM
Unknown Object (File)
Tue, Oct 14, 12:46 AM
Unknown Object (File)
Wed, Oct 8, 10:49 PM
Unknown Object (File)
Wed, Oct 8, 2:52 PM
Unknown Object (File)
Wed, Oct 8, 4:50 AM
Unknown Object (File)
Tue, Sep 16, 7:12 PM
Unknown Object (File)
Sep 12 2025, 10:24 AM
Unknown Object (File)
Sep 12 2025, 4:31 AM

Details

Summary

Remove redeclaration found by gcc build

These functions are also in ice_osdep.h and ice_nvm.h, where seems to be more
suitable.

Test Plan

Build with gcc and clang.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lwhsu requested review of this revision.Aug 5 2020, 5:26 AM
lwhsu created this revision.

The latter nvm related functions can be removed immediately; these have been removed in a newer version of the driver.

ice_free_list() doesn't even appear to be defined, and I think it is ok to have the other functions declared/defined in ice_osdep.h instead of ice_common.h.

I'm not sure why they are there in ice_common.h.

erj added a subscriber: jacob.e.keller_intel.com.

@jacob.e.keller_intel.com do you maybe have any thoughts on this, too?

This revision is now accepted and ready to land.Aug 10 2020, 10:29 PM
This revision was automatically updated to reflect the committed changes.