Page MenuHomeFreeBSD

Remove redeclaration found by gcc build
ClosedPublic

Authored by lwhsu on Aug 5 2020, 5:26 AM.

Details

Summary

Remove redeclaration found by gcc build

These functions are also in ice_osdep.h and ice_nvm.h, where seems to be more
suitable.

Test Plan

Build with gcc and clang.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 32763
Build 30198: arc lint + arc unit

Event Timeline

lwhsu requested review of this revision.Aug 5 2020, 5:26 AM
lwhsu created this revision.

The latter nvm related functions can be removed immediately; these have been removed in a newer version of the driver.

ice_free_list() doesn't even appear to be defined, and I think it is ok to have the other functions declared/defined in ice_osdep.h instead of ice_common.h.

I'm not sure why they are there in ice_common.h.

erj added a subscriber: jacob.e.keller_intel.com.

@jacob.e.keller_intel.com do you maybe have any thoughts on this, too?

This revision is now accepted and ready to land.Aug 10 2020, 10:29 PM
This revision was automatically updated to reflect the committed changes.