Page MenuHomeFreeBSD

Implement build and test using mage
Needs RevisionPublic

Authored by otis_sk.freebsd.org on Wed, Jul 29, 3:41 PM.

Details

Reviewers
dmgk
Group Reviewers
portmgr
Summary

While working on new sysutils/beats7, I found out that it is now being built using devel/mage.

This proposed change implements new argument for USES=go (mage)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

otis_sk.freebsd.org requested review of this revision.Wed, Jul 29, 3:41 PM
lwhsu added a reviewer: dmgk.Wed, Jul 29, 4:06 PM
mat added a comment.Mon, Aug 3, 12:17 PM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Mk/Uses/go.mk
143–150

In USES, we try to follow the order of stuff in a port's Makefile, so variable definitions should happen before targets start to be defined, so, just before the post-extract target.

179–184

Same for here.

  • diff with full context
  • reordered statements
mat accepted this revision as: portmgr.Mon, Aug 3, 1:41 PM
mat added inline comments.
Mk/Uses/go.mk
138–145

We usually write VARIABLE=<tab> to let code breathe, it makes it more readable for the brain by pre-splitting logical blocks of text.

141–143

You should probably put all this one one line, it would probably easier to read.

dmgk requested changes to this revision.Mon, Aug 3, 1:41 PM

I think the decision was to put this on hold unless more Go ports use mage for build.

This revision now requires changes to proceed.Mon, Aug 3, 1:41 PM