Page MenuHomeFreeBSD
Differential D25880

Implement build and test using mage
Needs RevisionPublic
Actions

Authored by otis on Jul 29 2020, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 6:46 PM
Unknown Object (File)
Sat, May 4, 8:35 AM
Unknown Object (File)
Fri, May 3, 12:35 PM
Unknown Object (File)
Wed, May 1, 12:20 PM
Unknown Object (File)
Apr 10 2024, 3:12 AM
Unknown Object (File)
Mar 31 2024, 8:26 AM
Unknown Object (File)
Feb 29 2024, 11:20 AM
Unknown Object (File)
Jan 19 2024, 9:41 AM
View All 16 Files
Subscribers
mat
Contributor Reviewers (ports)

Details

Reviewers
dmgk
Group Reviewers
portmgr
Summary

While working on new sysutils/beats7, I found out that it is now being built using devel/mage.

This proposed change implements new argument for USES=go (mage)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

otis created this revision.Jul 29 2020, 3:41 PM
Herald added a reviewer: portmgr. · View Herald TranscriptJul 29 2020, 3:41 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald Transcript
otis requested review of this revision.Jul 29 2020, 3:41 PM
otis updated this revision to Diff 75131.Jul 29 2020, 3:56 PM

Reduce diff

lwhsu added a reviewer: dmgk.Jul 29 2020, 4:06 PM
mat added a comment.Aug 3 2020, 12:17 PM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Mk/Uses/go.mk
143–150

In USES, we try to follow the order of stuff in a port's Makefile, so variable definitions should happen before targets start to be defined, so, just before the post-extract target.

179–184

Same for here.

otis updated this revision to Diff 75300.Aug 3 2020, 1:35 PM
  • diff with full context
  • reordered statements
mat accepted this revision as: portmgr.Aug 3 2020, 1:41 PM
mat added inline comments.
Mk/Uses/go.mk
138–145

We usually write VARIABLE=<tab> to let code breathe, it makes it more readable for the brain by pre-splitting logical blocks of text.

141–143

You should probably put all this one one line, it would probably easier to read.

dmgk requested changes to this revision.Aug 3 2020, 1:41 PM

I think the decision was to put this on hold unless more Go ports use mage for build.

This revision now requires changes to proceed.Aug 3 2020, 1:41 PM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
34 lines

Diff 75131

View Options

Mk/Uses/go.mk

Loading...