Page MenuHomeFreeBSD

Implement build and test using mage
Needs RevisionPublic

Authored by otis on Jul 29 2020, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 3:12 AM
Unknown Object (File)
Sun, Mar 31, 8:26 AM
Unknown Object (File)
Feb 29 2024, 11:20 AM
Unknown Object (File)
Jan 19 2024, 9:41 AM
Unknown Object (File)
Dec 23 2023, 12:41 AM
Unknown Object (File)
Nov 18 2023, 5:01 PM
Unknown Object (File)
Nov 18 2023, 5:01 PM
Unknown Object (File)
Nov 18 2023, 5:01 PM

Details

Reviewers
dmgk
Group Reviewers
portmgr
Summary

While working on new sysutils/beats7, I found out that it is now being built using devel/mage.

This proposed change implements new argument for USES=go (mage)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

otis requested review of this revision.Jul 29 2020, 3:41 PM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Mk/Uses/go.mk
143–150

In USES, we try to follow the order of stuff in a port's Makefile, so variable definitions should happen before targets start to be defined, so, just before the post-extract target.

179–184

Same for here.

  • diff with full context
  • reordered statements
mat added inline comments.
Mk/Uses/go.mk
138–145

We usually write VARIABLE=<tab> to let code breathe, it makes it more readable for the brain by pre-splitting logical blocks of text.

141–143

You should probably put all this one one line, it would probably easier to read.

dmgk requested changes to this revision.Aug 3 2020, 1:41 PM

I think the decision was to put this on hold unless more Go ports use mage for build.

This revision now requires changes to proceed.Aug 3 2020, 1:41 PM