Keep the shar example, but de-emphasize it and put it at the bottom, as suggested by @mat .

In D25148#555356, @mat wrote:

Could you maybe keep the example as it is now, and add a second example using shar ?

Approved.

It looks very good. I've been quite nit-picky about the patch meta data changes.

approved

Jup, this is good!

Hi!
After discussing this on the Graphics Team meeting today we all agreed that since this is a big update, and we are getting close to both the 11.4 release and the new quarterly ports branch, this has to wait until after the ports tree branch.
This does not mean this is an approval to commit this after the branch, but gives you a timeline of when at the earliest it can go in.

Hi!
This review requires some work to get going, and in our opinion we must get it right, since breaking this will break the whole graphics stack.

Does this require changes to drm-kmods?

Abandoning this since it's closed, but there seem to be no way to indicate that it's closed and committed if there's a mistake with the commit integration.

This has been updated as part of rP533793, but the phab integration missed it.

With regards to the API breakage, there has to be an overlap period where both the old and the new API works in order to have time to update ports, and to have those updates propagate.

Diff updated. I believe I got it right this time. :)

Update based on comments from @wulf .

Nice catch, thanks!

Minor nit above, nothing important.

Approved with my comment above.

LGTM

LGTM

In D23856#524763, @kevans wrote:

We could maybe MFC posix_fallocate support for shmfd, but it'd be a little contorted because we can't change struct fileops like we did in head. memfd_create could be MFC'd, but file sealing cannot and I'm not sure we want it if file sealing cannot be supported.

In D23856#524669, @jbeich wrote:

In D23856#524657, @zeising wrote:

This is a bug (or missing feature) in FreeBSD 12 that posix_fallocate() doesn't work with shm_open()?

Missing feature but using posix_fallocate with shm_open is unusual compared to memfd_create.

Should we poke @kevans about merging that change to FreeBSD 12 if possible?

Existing -RELEASE that haven't reached EOL still need to be supported in ports/. Backporting memfd_create would be more useful but maybe more risky.

Would this affect xorg-server as well?
I believe you have to make the UPDATING more verbose, to explain to people more about the change. They might not be aware of libxkbcommon, or which of xf86-input-libinput and xf86-input-keyboard they use. Perhaps you can add part of pkg-message also to updating?

I also wonder if we have the same pattern of shm_open() posix_fallocate() in other places (mesa comes to mind). I haven't looked though.

Can you please explain this to me a bit more, please?
This is a bug (or missing feature) in FreeBSD 12 that posix_fallocate() doesn't work with shm_open()? Should we poke @kevans about merging that change to FreeBSD 12 if possible?
I believe that the code will call os_resize_anonyous_file(), which call posix_fallocate(), even with the call to memfd_create(), if this works on FreeBSD 13, perhaps the patch should be made conditional on that version anyway? Or am I misreading the wayland code?
Apologies for all the question, I'm just a bit confused trying to understand it all.
Thank you for debugging this!