graphics/wayland-protocols: update to 1.20
ClosedPublic
Actions

Authored by jbeich on Mar 1 2020, 1:05 PM.

Details

Reviewers

manu
imp
zeising

Group Reviewers

x11

Commits

rP527797: graphics/wayland-protocols: update to 1.20

Summary

https://lists.freedesktop.org/archives/wayland-devel/2020-February/041267.html
https://lists.freedesktop.org/archives/wayland-devel/2020-February/041269.html
https://gitlab.freedesktop.org/wayland/wayland-protocols/compare/1.18...1.20

Test Plan

Builds fine on:

11.3 aarch64
11.3 amd64
11.3 armv6
11.3 i386
12.0 amd64
12.0 i386
12.1 aarch64
12.1 amd64
12.1 armv6
12.1 armv7
12.1 i386
13.0 amd64
13.0 i386
Base GCC 4.2.1 (mimics powerpc*, mips*, riscv64)
All consumers

Works fine on:

www/firefox + MOZ_ENABLE_WAYLAND
x11-servers/xwayland-devel
x11-wm/sway

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jbeich created this revision.Mar 1 2020, 1:05 PM

Harbormaster completed remote builds in B29703: Diff 69026.Mar 1 2020, 1:05 PM

jbeich edited the summary of this revision. (Show Details)Mar 1 2020, 5:04 PM

LGTM.
Thanks.

This revision is now accepted and ready to land.Mar 4 2020, 8:24 AM

The ports part of this looks good to me. It would be nice to have a better summary than the commit log between 1.18 and 1.20, though. It looks like the only changes are in the popup menu/window protocols, so that might make a good summary.
The also looks like it won't affect the X server at all and shouldn't break anything major since it's been smoke tested with firefox.
Thanks for updating.

LGTM

In D23906#526539, @imp wrote:

The also looks like it won't affect the X server at all and shouldn't break anything major since it's been smoke tested with firefox.

www/firefox doesn't use graphics/wayland-protocols during build unlike x11-servers/xorg-server which uses it via xwayland slave. If anything this could break consumers that rely on unstable protocols. Given there're few standardized protocols the risk is lower than x11/xorgproto updates which are already a low risk.

In short, everything but "all consumers" built fine was irrelevant to QA.

Closed by commit rP527797: graphics/wayland-protocols: update to 1.20 (authored by jbeich). · Explain WhyMar 4 2020, 8:34 PM

This revision was automatically updated to reflect the committed changes.

jbeich added a commit: rP527797: graphics/wayland-protocols: update to 1.20.

In D23906#526676, @jbeich wrote:

In D23906#526539, @imp wrote:

The also looks like it won't affect the X server at all and shouldn't break anything major since it's been smoke tested with firefox.

www/firefox doesn't use graphics/wayland-protocols during build unlike x11-servers/xorg-server which uses it via xwayland slave. If anything this could break consumers that rely on unstable protocols. Given there're few standardized protocols the risk is lower than x11/xorgproto updates which are already a low risk.

In short, everything but "all consumers" built fine was irrelevant to QA.