Page MenuHomeFreeBSD

x11/libwacom: unbreak "make test"
ClosedPublic

Authored by jbeich on Mar 8 2020, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 4:10 AM
Unknown Object (File)
Mar 22 2024, 1:07 PM
Unknown Object (File)
Mar 22 2024, 9:47 AM
Unknown Object (File)
Mar 9 2024, 2:27 PM
Unknown Object (File)
Mar 9 2024, 2:14 PM
Unknown Object (File)
Dec 20 2023, 4:44 AM
Unknown Object (File)
Nov 30 2023, 7:03 AM
Unknown Object (File)
Nov 6 2023, 7:14 PM
Subscribers

Details

Reviewers
zeising
Group Reviewers
x11
Commits
rP528827: x11/libwacom: unbreak "make test"
Test Plan
  1. Add BUILD_DEPENDS+=${TEST_DEPENDS} to Makefile.local
  2. Add pre-install: do-test to Makefile.local
  3. Run poudriere testport x11/libwacom

(1) and (2) are workarounds for https://github.com/freebsd/poudriere/pull/355

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

x11/libwacom/Makefile
23 ↗(On Diff #69310)

Note1, upstream rejected POSIX shell in favor of readability. FreeBSD sh and other utilities are not pure POSIX anyway, so one can't expect other BSDs or GNU dash to have the same extensions.
Note2, any bash from PATH would do. bash -> zsh symlink works fine i.e., sometimes Zsh is faster Bash than GNU Bash. ;)

What bashism is needed / used here?

Ping. Making non-upstreamable changes is outside of scope for this review.

This revision is now accepted and ready to land.Mar 20 2020, 11:48 PM
This revision was automatically updated to reflect the committed changes.