Page MenuHomeFreeBSD
Feed Advanced Search

Nov 18 2016

wblock added a comment to D8382: Replace basename(3) by a thread-safe implementation. .

Sorry for the late reply... no major complaints. For the future, remember that "may" usually implies permission ("yes, you may overwrite that file now"), while "might" is usually better to use to say that something might or might not happen: "this function might return a pointer to a random area of memory". Also, try to avoid "the former" or "the latter", because it forces the reader to stop and look back to see which is which.

Nov 18 2016, 3:25 PM

Nov 10 2016

wblock added a comment to D8483: Add Samba4 instructions to Network Servers section of the handbook.

This diff has no context, so it is difficult to review. Please update the diff with full context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface

Nov 10 2016, 7:44 PM
wblock added a comment to D8483: Add Samba4 instructions to Network Servers section of the handbook.

This diff has no context, so it is difficult to review. Please update the diff with full context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface

Nov 10 2016, 6:02 PM

Nov 2 2016

wblock accepted D8362: Split up the __FreeBSD_version table per releases..
Nov 2 2016, 7:42 PM
wblock added a comment to D8362: Split up the __FreeBSD_version table per releases..
In D8362#175166, @mat wrote:

There are more than one commit, the whitespace fixes will go in separate commits.

Nov 2 2016, 7:42 PM
wblock committed rD49626: Fix name, expand contraction..
Fix name, expand contraction.
Nov 2 2016, 1:49 PM
wblock added a comment to D8362: Split up the __FreeBSD_version table per releases..

Some of these are whitespace-only changes. I don't know how many groups have translated this document, though.

Nov 2 2016, 2:36 AM

Oct 29 2016

wblock committed rD49609: Clarify in context to show that 'man -k' can be used to search for.
Clarify in context to show that 'man -k' can be used to search for
Oct 29 2016, 1:49 PM

Oct 28 2016

wblock committed rD49604: Whitespace-only fixes, translators please ignore..
Whitespace-only fixes, translators please ignore.
Oct 28 2016, 6:59 PM
wblock committed rD49603: Grammar and spelling changes, comma and semicolon reductions, run-on.
Grammar and spelling changes, comma and semicolon reductions, run-on
Oct 28 2016, 6:11 PM
wblock committed rD49600: NTP is UDP port 123..
NTP is UDP port 123.
Oct 28 2016, 3:31 PM
wblock closed D8375: Update outbound NTP rule in the IPFW configuration section: Bug report #213365 by committing rD49600: NTP is UDP port 123..
Oct 28 2016, 3:31 PM
wblock committed rD49599: USB pass-through in VirtualBox is currently not supported..
USB pass-through in VirtualBox is currently not supported.
Oct 28 2016, 2:26 PM
wblock closed D8318: Add note to section 21.6.: VirtualBox USB support - USB 2.0 and 3.0 pass through not supported (from bug ticket #207630: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207630) by committing rD49599: USB pass-through in VirtualBox is currently not supported..
Oct 28 2016, 2:26 PM
wblock accepted D8318: Add note to section 21.6.: VirtualBox USB support - USB 2.0 and 3.0 pass through not supported (from bug ticket #207630: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207630).
Oct 28 2016, 2:19 PM
wblock added a comment to D8362: Split up the __FreeBSD_version table per releases..

I think this is a good idea. To go a step further, would it be more useful to have the tables in major revision descending order? FreeBSD 12 first, then 11, 10, and so on. As it is, most readers will usually have to scroll to near the end.

Oct 28 2016, 1:58 PM

Oct 22 2016

wblock accepted D8324: Remove CTM entries from FAQ.

Looks good to me.

Oct 22 2016, 2:22 PM

Oct 21 2016

wblock committed rD49539: Explain the difference between memstick.img and mini-memstick.img..
Explain the difference between memstick.img and mini-memstick.img.
Oct 21 2016, 8:31 PM
wblock closed D8252: Bug report #213468 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213468): by committing rD49539: Explain the difference between memstick.img and mini-memstick.img..
Oct 21 2016, 8:31 PM
wblock added inline comments to D8318: Add note to section 21.6.: VirtualBox USB support - USB 2.0 and 3.0 pass through not supported (from bug ticket #207630: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207630).
Oct 21 2016, 8:17 PM
wblock added a comment to D8273: Traditional Chinese Translation of handbook (Update ZFS).

The sheer quantity of this work is amazing. Thank you!

Oct 21 2016, 2:26 PM

Oct 17 2016

wblock accepted D7847: Move mksubr from kdump into libsysdecode..

Wow, the rendered version is not only shorter but easier to read. Thank you!

Oct 17 2016, 12:16 PM

Oct 16 2016

wblock accepted D8172: add iic interface to ig4 driver, move isl and cyapa to iicbus.

Thank you!

Oct 16 2016, 5:51 PM
wblock accepted D7612: zfsbootcfg: a simple tool to set next boot (one time) options for zfsboot.

Thank you!

Oct 16 2016, 5:48 PM
wblock accepted D8174: jedec_ts: a driver for temperature sensors on memory modules.

Man page looks good, but please test with mandoc -Tlint and igor -Rbefore commit. Thanks!

Oct 16 2016, 5:39 PM

Oct 14 2016

wblock added inline comments to D8252: Bug report #213468 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213468):.
Oct 14 2016, 7:20 PM
wblock added inline comments to D8252: Bug report #213468 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213468):.
Oct 14 2016, 7:03 PM
wblock added inline comments to D8252: Bug report #213468 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213468):.
Oct 14 2016, 6:32 PM
wblock added a comment to D7612: zfsbootcfg: a simple tool to set next boot (one time) options for zfsboot.
In D7612#171511, @avg wrote:

@wblock I remember making them and updating the diff.
I look at this https://reviews.freebsd.org/D7612?vs=21017&id=21295&whitespace=ignore-most#toc and I see the changes.

Oct 14 2016, 5:35 PM
wblock added inline comments to D7828: Add -p (physpath) and -s (serial#) to diskinfo.
Oct 14 2016, 5:24 PM
wblock added inline comments to D8234: Add pmcstat flag for specifying kernel module paths.
Oct 14 2016, 5:07 PM
wblock added a comment to D7612: zfsbootcfg: a simple tool to set next boot (one time) options for zfsboot.
In D7612#171485, @avg wrote:
In D7612#170785, @avg wrote:

@wblock thank you!

You're welcome, but none of them seem to have changed the source.

Apologies, I failed to understand this comment... could you please explain?

Oct 14 2016, 4:37 PM
wblock added inline comments to D8172: add iic interface to ig4 driver, move isl and cyapa to iicbus.
Oct 14 2016, 4:13 PM
wblock added a comment to D7612: zfsbootcfg: a simple tool to set next boot (one time) options for zfsboot.
In D7612#170785, @avg wrote:

@wblock thank you!

Oct 14 2016, 4:06 PM
wblock added inline comments to D7847: Move mksubr from kdump into libsysdecode..
Oct 14 2016, 3:52 PM
wblock added inline comments to D8205: Improve typing of POSIX search tree functions..
Oct 14 2016, 3:13 PM
wblock added inline comments to D8174: jedec_ts: a driver for temperature sensors on memory modules.
Oct 14 2016, 3:09 PM

Oct 13 2016

wblock committed rD49510: Correct versions where serial devices changed from cuad to cuau..
Correct versions where serial devices changed from cuad to cuau.
Oct 13 2016, 2:48 AM

Oct 12 2016

wblock committed rD49507: Remove an extraneous "and"..
Remove an extraneous "and".
Oct 12 2016, 8:01 PM

Oct 11 2016

wblock committed rD49499: Add an entry for Stormshield, submitted by gnn..
Add an entry for Stormshield, submitted by gnn.
Oct 11 2016, 7:57 PM

Oct 7 2016

wblock accepted D8183: Additional cleanup of the arp(4) man page after r306652..

Macro goatforit: I'm approving this as hard as I can

Oct 7 2016, 7:32 PM
wblock accepted D8183: Additional cleanup of the arp(4) man page after r306652..

Please do the standard mandoc -Tlint and igor -R tests, but looks good to me. Thanks!

Oct 7 2016, 6:39 PM
wblock added a comment to D8183: Additional cleanup of the arp(4) man page after r306652..

Thank you for doing this!

Oct 7 2016, 6:16 PM
wblock added a comment to D7035: Remove the Fuzzy flags of several strings in the po file of zh_TW fdp-primer.

I'm sorry for the delay on this, but have found no better way to address these problems. I suggest that we commit this as better than what was there previously.

Oct 7 2016, 5:07 PM
wblock added inline comments to D8136: Update the arp(4) man page to document the net.link.ether.inet.garp_rexmit_count sysctl..
Oct 7 2016, 4:58 PM
wblock added inline comments to D8172: add iic interface to ig4 driver, move isl and cyapa to iicbus.
Oct 7 2016, 4:06 PM
wblock accepted D8156: Fix broken link to PDF using archived copy on archive.org.

No problem, looks good to me too.

Oct 7 2016, 3:51 PM
wblock added inline comments to D8154: Man page for capsicum helpers..
Oct 7 2016, 3:45 PM
wblock accepted D8142: Remove historical /boot/boot.conf inclusion..

Remember to bump .Dd on loader.8.

Oct 7 2016, 3:37 PM
wblock added inline comments to D8128: UEFI Runtime Services environment variable support..
Oct 7 2016, 3:35 PM
wblock added inline comments to D7115: Support configuration of an interface to use a DHCPv6 client..
Oct 7 2016, 3:27 PM
wblock added inline comments to D8136: Update the arp(4) man page to document the net.link.ether.inet.garp_rexmit_count sysctl..
Oct 7 2016, 3:24 PM
wblock added a comment to D7993: daemon(8): Alternate approach for logging via syslog.

Man page looks okay to me. Thank you!

Oct 7 2016, 3:12 PM
wblock added a comment to D8012: Fix race in taskqueue_drain_timeout().
Oct 7 2016, 3:06 PM
wblock added inline comments to D7847: Move mksubr from kdump into libsysdecode..
Oct 7 2016, 3:04 PM
wblock added a comment to D8126: swapoff: Remove only late devices with -aL..

Man page changes look okay. Given the choice, I'd change all of them from "will be" to "are", but that's out of the scope of this change.

Oct 7 2016, 2:55 PM
wblock added inline comments to D7612: zfsbootcfg: a simple tool to set next boot (one time) options for zfsboot.
Oct 7 2016, 2:50 PM

Oct 5 2016

wblock added inline comments to D8156: Fix broken link to PDF using archived copy on archive.org.
Oct 5 2016, 8:30 PM
wblock added a comment to D8156: Fix broken link to PDF using archived copy on archive.org.

This is fine. Would you like to fix the sentence that leads up to it while we are here?

Oct 5 2016, 6:18 PM

Sep 30 2016

wblock added inline comments to D7612: zfsbootcfg: a simple tool to set next boot (one time) options for zfsboot.
Sep 30 2016, 9:01 PM
wblock added inline comments to D3390: improvements to kproc/kthread man pages.
Sep 30 2016, 8:57 PM
wblock accepted D7947: Capsicumify open.2.

Macro goatforit: goat for it

Sep 30 2016, 8:52 PM
wblock updated the diff for D7665: Rewrite the Updating from Source section of the Handbook.

Updated for feedback.

Sep 30 2016, 7:03 PM
wblock added inline comments to D7665: Rewrite the Updating from Source section of the Handbook.
Sep 30 2016, 7:02 PM
wblock added inline comments to D8016: Document thr_suspend(2) and thr_wake(2)..
Sep 30 2016, 3:55 PM · manpages
wblock added inline comments to D3687: Implement kernel support for hardware rate limited sockets.
Sep 30 2016, 3:30 PM
wblock added inline comments to D8012: Fix race in taskqueue_drain_timeout().
Sep 30 2016, 3:11 PM
wblock added inline comments to D8023: Editing for cap_enter(2) and procctl(2)..
Sep 30 2016, 3:09 PM
wblock added inline comments to D8016: Document thr_suspend(2) and thr_wake(2)..
Sep 30 2016, 3:06 PM · manpages
wblock added inline comments to D7993: daemon(8): Alternate approach for logging via syslog.
Sep 30 2016, 3:03 PM
wblock added inline comments to D7947: Capsicumify open.2.
Sep 30 2016, 2:35 PM

Sep 23 2016

wblock added inline comments to D7983: style.9: Additional minor clarification and phrasing.
Sep 23 2016, 7:51 PM
wblock accepted D8018: Mount msdosfs with longnames support by default..
Sep 23 2016, 6:02 PM
wblock added inline comments to D8016: Document thr_suspend(2) and thr_wake(2)..
Sep 23 2016, 5:53 PM · manpages
wblock added inline comments to D8003: Document trapcap..
Sep 23 2016, 5:29 PM · manpages
wblock added inline comments to D7993: daemon(8): Alternate approach for logging via syslog.
Sep 23 2016, 5:03 PM
wblock added inline comments to D7983: style.9: Additional minor clarification and phrasing.
Sep 23 2016, 4:32 PM
wblock added inline comments to D7947: Capsicumify open.2.
Sep 23 2016, 4:03 PM

Sep 16 2016

wblock committed rS305887: Update history. Patch supplied by Sevan Janiyan <venture37@geeklan.co.uk>..
Update history. Patch supplied by Sevan Janiyan <venture37@geeklan.co.uk>.
Sep 16 2016, 2:23 PM
wblock added inline comments to D7851: Porters Handbook: Fix typo, add a bit of detail to verbose builds `do'.
Sep 16 2016, 2:08 PM
wblock added a comment to D7847: Move mksubr from kdump into libsysdecode..

Remember to bump .Dd in the four man pages. Thanks!

Sep 16 2016, 2:06 PM
wblock accepted D7877: Add manpage for rctl_* system calls.

Works for me. Please run mandoc -Tlint and igor -R on it to check for unexpected problems before commit.

Sep 16 2016, 2:00 PM
wblock accepted D7883: Remove backup_uses_rcs.

Thank you!

Sep 16 2016, 1:51 PM

Sep 15 2016

wblock added a comment to D7877: Add manpage for rctl_* system calls.

Very nice! My only suggestions are:

Sep 15 2016, 2:11 AM

Sep 13 2016

wblock committed rS305758: Add another badly-needed simple example to the pw(8) man page..
Add another badly-needed simple example to the pw(8) man page.
Sep 13 2016, 2:18 AM

Sep 11 2016

wblock added inline comments to D7849: Add instructions for LICENSE and LICENSE_FILE to the Porter's Handbook.
Sep 11 2016, 6:20 PM
wblock added a reviewer for D7849: Add instructions for LICENSE and LICENSE_FILE to the Porter's Handbook: wblock.
Sep 11 2016, 6:14 PM

Sep 9 2016

wblock accepted D7803: Make device_quiet() an attachment property..

Thank you!

Sep 9 2016, 11:38 PM
wblock added inline comments to D7822: describe flag returned by `cap_getmode`.
Sep 9 2016, 11:34 PM
wblock accepted D7533: Introduce policy of preferring verbose logs.

I find this cromulent.

Sep 9 2016, 8:02 PM
wblock added inline comments to D7533: Introduce policy of preferring verbose logs.
Sep 9 2016, 7:54 PM
wblock committed rD49377: Change the ssh-keygen example to RSA. Remove mention of DSA. Clean up.
Change the ssh-keygen example to RSA. Remove mention of DSA. Clean up
Sep 9 2016, 5:32 PM
wblock committed rD49376: Update anti-aliased fonts section. Patch supplied by Tim Moore.
Update anti-aliased fonts section. Patch supplied by Tim Moore
Sep 9 2016, 3:34 PM
wblock closed D7841: Fix bug #193612 by committing rD49376: Update anti-aliased fonts section. Patch supplied by Tim Moore.
Sep 9 2016, 3:34 PM
wblock accepted D7841: Fix bug #193612.

Krelbf the snootlax!

Sep 9 2016, 3:01 PM
wblock added a comment to D7841: Fix bug #193612.

One last thing...

Sep 9 2016, 2:50 PM
wblock added inline comments to D7841: Fix bug #193612.
Sep 9 2016, 2:40 PM
wblock added inline comments to D7803: Make device_quiet() an attachment property..
Sep 9 2016, 2:05 PM
wblock added inline comments to D7822: describe flag returned by `cap_getmode`.
Sep 9 2016, 2:02 PM
wblock added inline comments to D7841: Fix bug #193612.
Sep 9 2016, 1:34 PM