Sorry for the late reply... no major complaints. For the future, remember that "may" usually implies permission ("yes, you may overwrite that file now"), while "might" is usually better to use to say that something might or might not happen: "this function might return a pointer to a random area of memory". Also, try to avoid "the former" or "the latter", because it forces the reader to stop and look back to see which is which.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 18 2016
Nov 10 2016
This diff has no context, so it is difficult to review. Please update the diff with full context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface
This diff has no context, so it is difficult to review. Please update the diff with full context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface
Nov 2 2016
In D8362#175166, @mat wrote:There are more than one commit, the whitespace fixes will go in separate commits.
Some of these are whitespace-only changes. I don't know how many groups have translated this document, though.
Oct 29 2016
Oct 28 2016
I think this is a good idea. To go a step further, would it be more useful to have the tables in major revision descending order? FreeBSD 12 first, then 11, 10, and so on. As it is, most readers will usually have to scroll to near the end.
Oct 22 2016
Oct 21 2016
The sheer quantity of this work is amazing. Thank you!
Oct 17 2016
Wow, the rendered version is not only shorter but easier to read. Thank you!
Oct 16 2016
Thank you!
Thank you!
Man page looks good, but please test with mandoc -Tlint and igor -Rbefore commit. Thanks!
Oct 14 2016
In D7612#171511, @avg wrote:@wblock I remember making them and updating the diff.
I look at this https://reviews.freebsd.org/D7612?vs=21017&id=21295&whitespace=ignore-most#toc and I see the changes.
In D7612#171485, @avg wrote:In D7612#171482, @wblock wrote:In D7612#170785, @avg wrote:@wblock thank you!
You're welcome, but none of them seem to have changed the source.
Apologies, I failed to understand this comment... could you please explain?
In D7612#170785, @avg wrote:@wblock thank you!
Oct 13 2016
Oct 12 2016
Oct 11 2016
Oct 7 2016
Please do the standard mandoc -Tlint and igor -R tests, but looks good to me. Thanks!
Thank you for doing this!
I'm sorry for the delay on this, but have found no better way to address these problems. I suggest that we commit this as better than what was there previously.
No problem, looks good to me too.
Remember to bump .Dd on loader.8.
Man page looks okay to me. Thank you!
Man page changes look okay. Given the choice, I'd change all of them from "will be" to "are", but that's out of the scope of this change.
Oct 5 2016
This is fine. Would you like to fix the sentence that leads up to it while we are here?
Sep 30 2016
Updated for feedback.
Sep 23 2016
Sep 16 2016
Remember to bump .Dd in the four man pages. Thanks!
Works for me. Please run mandoc -Tlint and igor -R on it to check for unexpected problems before commit.
Sep 15 2016
Very nice! My only suggestions are:
Sep 13 2016
Sep 11 2016
Sep 9 2016
I find this cromulent.