Page MenuHomeFreeBSD
Differential D8483

Add Samba4 instructions to Network Servers section of the handbook
ClosedPublic
Actions

Authored by sevan on Nov 9 2016, 7:36 PM.
Tags
None
Referenced Files
F86801536: D8483.diff
Tue, Jun 25, 6:48 PM
Unknown Object (File)
Thu, Jun 20, 5:07 PM
Unknown Object (File)
Apr 26 2024, 10:52 PM
Unknown Object (File)
Apr 26 2024, 10:52 PM
Unknown Object (File)
Apr 26 2024, 10:52 PM
Unknown Object (File)
Apr 26 2024, 10:52 PM
Unknown Object (File)
Apr 26 2024, 10:52 PM
Unknown Object (File)
Apr 26 2024, 8:52 PM
View All 39 Files
Subscribers
wblock

Details

Reviewers
bcr
Commits
rD49710: Add punctuation as advised by wblock@
Summary

Bug 213074

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sevan updated this revision to Diff 22112.Nov 9 2016, 7:36 PM
sevan retitled this revision from to Add Samba4 instructions to Network Servers section of the handbook.
sevan updated this object.
sevan edited the test plan for this revision. (Show Details)
sevan added a reviewer: bcr.
sevan set the repository for this revision to rD FreeBSD doc repository - subversion.
bcr edited edge metadata.Nov 10 2016, 5:49 PM

Style fix.

en_US.ISO8859-1/books/handbook/network-servers/chapter.xml
5243 ↗(On Diff #22112)

That line needs to have a line break above it. Same as the <programlisting> above the <para>.

wblock added a subscriber: wblock.Nov 10 2016, 6:02 PM

This diff has no context, so it is difficult to review. Please update the diff with full context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface

wblock added a comment.Nov 10 2016, 7:44 PM

This diff has no context, so it is difficult to review. Please update the diff with full context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview#Create_a_Revision_via_Web_Interface

en_US.ISO8859-1/books/handbook/network-servers/chapter.xml
5256 ↗(On Diff #22112)

This is a whitespace-only change that should be committed separately from content changes.

sevan updated this revision to Diff 22171.Nov 12 2016, 3:46 PM
sevan edited edge metadata.
sevan marked 2 inline comments as done.

Updated diff with the points addressed hopefully.

bcr accepted this revision.Nov 12 2016, 10:55 PM
bcr edited edge metadata.

This looks good enough now, so go for it!

This revision is now accepted and ready to land.Nov 12 2016, 10:55 PM
wblock added inline comments.Nov 18 2016, 5:01 PM
en_US.ISO8859-1/books/handbook/network-servers/chapter.xml
5242 ↗(On Diff #22171)

With context, I think there should be a comma in here:

<para>To enable Samba4, use:</para>
sevan updated this revision to Diff 22709.Dec 5 2016, 1:56 AM
sevan edited edge metadata.
This revision now requires review to proceed.Dec 5 2016, 1:56 AM
sevan marked an inline comment as done.Dec 5 2016, 1:56 AM

Comma added in new diff.

bcr accepted this revision.Dec 5 2016, 7:18 AM
bcr edited edge metadata.

OK to commit.

This revision is now accepted and ready to land.Dec 5 2016, 7:18 AM
Closed by commit rD49710: Add punctuation as advised by wblock@ (authored by sevan). · Explain WhyDec 5 2016, 1:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
books/
handbook/
network-servers/
2 lines

Diff 22714

View Options

head/en_US.ISO8859-1/books/handbook/network-servers/chapter.xml

Loading...