Page MenuHomeFreeBSD

Editing for cap_enter(2) and procctl(2).
ClosedPublic

Authored by kib on Sep 24 2016, 7:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 9 2024, 7:13 AM
Unknown Object (File)
May 9 2024, 7:13 AM
Unknown Object (File)
May 9 2024, 7:13 AM
Unknown Object (File)
May 8 2024, 8:21 PM
Unknown Object (File)
Mar 19 2024, 11:53 AM
Unknown Object (File)
Mar 3 2024, 7:32 AM
Unknown Object (File)
Mar 3 2024, 7:07 AM
Unknown Object (File)
Dec 22 2023, 9:06 PM

Details

Summary

This is a continuation for D8003.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib retitled this revision from to Editing for cap_enter(2) and procctl(2)..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added a reviewer: wblock.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
kib added subscribers: emaste, cem.
cem added a reviewer: cem.
cem added inline comments.
lib/libc/sys/cap_enter.2
75–76 ↗(On Diff #20669)

is it sufficient to remove ", then for any process executing in a capability mode sandbox, "? After all, these errors only occur there. It simplifies the sentence but is maybe less clear if readers are unfamiliar with ENOTCAPABLE/ECAPMODE.

This revision is now accepted and ready to land.Sep 24 2016, 3:57 PM
lib/libc/sys/cap_enter.2
75–76 ↗(On Diff #20669)

My feel is that a complicated sentence which provides explicit context is overall easier to understand _right_ than the simpler stripped-down statement, in this case.

lib/libc/sys/cap_enter.2
75–76 ↗(On Diff #20669)

Works for me.

jilles added inline comments.
lib/libc/sys/cap_enter.2
75–76 ↗(On Diff #20669)

What's more, [ENOTCAPABLE] may occur outside of capability mode, since capability rights are always respected. This might be useful when passing a file descriptor to a process with a lower privilege level. In this case, no SIGTRAP occurs.

This revision was automatically updated to reflect the committed changes.
head/lib/libc/sys/cap_enter.2
76

s/either/either an/