Page MenuHomeFreeBSD

Additional cleanup of the arp(4) man page after r306652.
ClosedPublic

Authored by dab on Oct 7 2016, 6:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 6:32 AM
Unknown Object (File)
Fri, Dec 6, 1:19 AM
Unknown Object (File)
Nov 18 2024, 11:23 AM
Unknown Object (File)
Nov 17 2024, 8:38 PM
Unknown Object (File)
Nov 10 2024, 2:40 PM
Unknown Object (File)
Oct 30 2024, 10:28 AM
Unknown Object (File)
Oct 3 2024, 11:51 PM
Unknown Object (File)
Oct 3 2024, 9:44 PM
Subscribers
None

Details

Summary

Additional cleanup of the arp(4) man page after r306652.

Requested by: wblock@

Test Plan

Run igor, run mandoc -Tlint, run man and visually verify change.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dab retitled this revision from to Additional cleanup of the arp(4) man page after r306652..
dab updated this object.
dab edited the test plan for this revision. (Show Details)
dab added reviewers: vangyzen, wblock.

Thank you for doing this!

usr.sbin/arp/arp.4
132 ↗(On Diff #21157)

Don't need "of this sysctl".
s/will cause/causes/

148 ↗(On Diff #21157)

s/an other/another/

154 ↗(On Diff #21157)

Not really sure what "on the network" means here.

160 ↗(On Diff #21157)

Maybe "...when the IP network to which the address belongs is connected..."

usr.sbin/arp/arp.4
148 ↗(On Diff #21157)

An other one of those, eh? :-)

154 ↗(On Diff #21157)

Yes, it seems superfluous. I'll delete.

160 ↗(On Diff #21157)

Agreed; much better.

dab edited edge metadata.
  • Additional changes suggested by review.
dab marked 7 inline comments as done.Oct 7 2016, 6:31 PM
wblock edited edge metadata.

Please do the standard mandoc -Tlint and igor -R tests, but looks good to me. Thanks!

This revision is now accepted and ready to land.Oct 7 2016, 6:39 PM

Yep; did manioc -Tlint and igor. Neither have any complaints (well, igor complains about a contraction, but that is in the literal text of an error message, so I cannot do anything about that):

$ mandoc -Tlint ./usr.sbin/arp/arp.4
$ igor ./usr.sbin/arp/arp.4
arp.4:207:contraction:.It "arpresolve: [can't] allocate llinfo for %d.%d.%d.%d"

usr.sbin/arp/arp.4
124 ↗(On Diff #21160)

with the multicast bit

125 ↗(On Diff #21160)

is an RFC

126 ↗(On Diff #21160)

on the network

dab marked 3 inline comments as done.Oct 7 2016, 7:25 PM
dab edited edge metadata.
  • Additional minor tweaks to grammar and wording suggested by vangyzen@
This revision now requires review to proceed.Oct 7 2016, 7:25 PM
dab edited edge metadata.
  • Additional minor tweaks to grammar and wording suggested by vangyzen@
This revision is now accepted and ready to land.Oct 7 2016, 7:32 PM
vangyzen edited edge metadata.
This revision was automatically updated to reflect the committed changes.