Page MenuHomeFreeBSD
Differential D8183

Additional cleanup of the arp(4) man page after r306652.
ClosedPublic
Actions

Authored by dab on Oct 7 2016, 6:05 PM.
Tags
None
Referenced Files
F87088111: D8183.diff
Sat, Jun 29, 4:47 AM
Unknown Object (File)
Mon, Jun 24, 9:56 PM
Unknown Object (File)
Sat, Jun 22, 1:46 AM
Unknown Object (File)
May 24 2024, 9:18 PM
Unknown Object (File)
May 16 2024, 12:42 AM
Unknown Object (File)
Mar 22 2024, 4:49 PM
Unknown Object (File)
Mar 22 2024, 4:49 PM
Unknown Object (File)
Mar 22 2024, 4:48 PM
View All 69 Files
Subscribers
None

Details

Reviewers
wblock
vangyzen
Commits
rS306830: Additional cleanup of the arp(4) man page after r306652
Summary

Additional cleanup of the arp(4) man page after r306652.

Requested by: wblock@

Test Plan

Run igor, run mandoc -Tlint, run man and visually verify change.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5503
Build 5728: arc lint + arc unit

Event Timeline

dab updated this revision to Diff 21157.Oct 7 2016, 6:05 PM
dab retitled this revision from to Additional cleanup of the arp(4) man page after r306652..
dab updated this object.
dab edited the test plan for this revision. (Show Details)
dab added reviewers: vangyzen, wblock.
dab mentioned this in D8136: Update the arp(4) man page to document the net.link.ether.inet.garp_rexmit_count sysctl..Oct 7 2016, 6:11 PM
dab updated this object.
wblock edited edge metadata.Oct 7 2016, 6:16 PM

Thank you for doing this!

usr.sbin/arp/arp.4
131–132

Don't need "of this sysctl".
s/will cause/causes/

148

s/an other/another/

154

Not really sure what "on the network" means here.

160–161

Maybe "...when the IP network to which the address belongs is connected..."

dab added inline comments.Oct 7 2016, 6:29 PM
usr.sbin/arp/arp.4
148

An other one of those, eh? :-)

154

Yes, it seems superfluous. I'll delete.

160–161

Agreed; much better.

dab updated this revision to Diff 21160.Oct 7 2016, 6:30 PM
dab edited edge metadata.
  • Additional changes suggested by review.
dab marked 7 inline comments as done.Oct 7 2016, 6:31 PM
wblock accepted this revision.Oct 7 2016, 6:39 PM
wblock edited edge metadata.

Please do the standard mandoc -Tlint and igor -R tests, but looks good to me. Thanks!

This revision is now accepted and ready to land.Oct 7 2016, 6:39 PM
dab added a comment.Oct 7 2016, 6:59 PM

Yep; did manioc -Tlint and igor. Neither have any complaints (well, igor complains about a contraction, but that is in the literal text of an error message, so I cannot do anything about that):

$ mandoc -Tlint ./usr.sbin/arp/arp.4
$ igor ./usr.sbin/arp/arp.4
arp.4:207:contraction:.It "arpresolve: [can't] allocate llinfo for %d.%d.%d.%d"

vangyzen added inline comments.Oct 7 2016, 7:12 PM
usr.sbin/arp/arp.4
123–124

with the multicast bit

123–124

is an RFC

124–126

on the network

dab marked 3 inline comments as done.Oct 7 2016, 7:25 PM
dab updated this revision to Diff 21163.Oct 7 2016, 7:25 PM
dab edited edge metadata.
  • Additional minor tweaks to grammar and wording suggested by vangyzen@
This revision now requires review to proceed.Oct 7 2016, 7:25 PM
dab updated this revision to Diff 21164.Oct 7 2016, 7:26 PM
dab edited edge metadata.
  • Additional minor tweaks to grammar and wording suggested by vangyzen@
wblock accepted this revision.Oct 7 2016, 7:32 PM
wblock edited edge metadata.

Macro goatforit: I'm approving this as hard as I can

This revision is now accepted and ready to land.Oct 7 2016, 7:32 PM
vangyzen accepted this revision.Oct 7 2016, 10:10 PM
vangyzen edited edge metadata.
Closed by commit rS306830: Additional cleanup of the arp(4) man page after r306652 (authored by vangyzen). · Explain WhyOct 7 2016, 10:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
arp/
52 lines

Diff 21164

View Options

usr.sbin/arp/arp.4

Loading...