Page MenuHomeFreeBSD

jedec_ts: a driver for temperature sensors on memory modules
ClosedPublic

Authored by avg on Oct 7 2016, 8:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 5:20 PM
Unknown Object (File)
Thu, May 2, 5:08 PM
Unknown Object (File)
Thu, May 2, 5:08 PM
Unknown Object (File)
Thu, May 2, 5:07 PM
Unknown Object (File)
Thu, May 2, 5:06 PM
Unknown Object (File)
Thu, May 2, 5:05 PM
Unknown Object (File)
Thu, May 2, 1:24 PM
Unknown Object (File)
Thu, May 2, 12:10 PM
Subscribers

Details

Summary

The driver currently supports chips that are fully compliant with the
JEDEC SPD / EEPROM / TS standard (JEDEC Standard 21-C,
TSE2002 Specification, frequenlty referred to as JEDEC JC 42.4).

Additionally some chips from STMicroelectronics are supported as well.
They are compliant except for their Device ID pattern.

Test Plan

Tested on hardware that I have access to:
KVR16E11S8/4 memory modules with STTS424E02 chip (compines a temperature
sensor and an SPD EEPROM).
Example:
dev.jedec_ts.0.temp: 39.2500C

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg retitled this revision from to jedec_ts: a driver for temperature sensors on memory modules.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added reviewers: imp, jhb.
sys/dev/jedec_ts/jedec_ts.c
103 ↗(On Diff #21137)

It would be safer to put all this in the attach routine.
Most of the I2C drivers just assume the probe is good.
There are a few that write to the chip during the probe.

sys/dev/jedec_ts/jedec_ts.c
103 ↗(On Diff #21137)

Is this to avoid fiddling with the hardware in case that a more specific driver wins the device during probing?
I'll make the change.

avg edited edge metadata.

jedec_ts: move hardware probing to the attach routine

This is done, so that another, more specific driver could claim
the device before this driver has a chance to mess up the hardware.

avg marked 2 inline comments as done.Oct 12 2016, 7:30 AM
avg edited edge metadata.
  • actually allow to be compiled into the kernel
  • add to NOTES / LINT
  • some clean-ups in the manual page
wblock added inline comments.
share/man/man4/jedec_ts.4
79 ↗(On Diff #21342)

Not sure if .Va should be included in the parameter as it is invisible, but at worst it just gives an extra three spaces of indent.

85 ↗(On Diff #21342)

Needs a comma:

.Xr device.hints 5 ,
99 ↗(On Diff #21342)

Generally, numbers less than ten should be spelled out.

100 ↗(On Diff #21342)

As above, s/8/eight/.

avg edited edge metadata.

man page fixes suggested by wblock

avg marked 4 inline comments as done.Oct 15 2016, 9:26 AM
wblock added a reviewer: wblock.

Man page looks good, but please test with mandoc -Tlint and igor -Rbefore commit. Thanks!

This revision is now accepted and ready to land.Oct 16 2016, 5:38 PM
avg edited edge metadata.

add jedec_ts to modules/i2c/Makefile

This revision now requires review to proceed.Oct 17 2016, 7:39 AM

If there are no objections or requests for changes, I would like to commit this driver sooner rather than later.

This revision was automatically updated to reflect the committed changes.