Mount msdosfs with longnames support by default.
ClosedPublic
Actions

Authored by asomers on Sep 23 2016, 4:55 PM.

Details

Reviewers

cem
trasz
wblock
imp
adrian

Group Reviewers

manpages

Commits

rS306276: Mount msdosfs with longnames support by default.

Summary

Mount msdosfs with longnames support by default.

The old behavior depended on the FAT version and on what files were in the
root directory. "mount_msdosfs -o shortnames" is still supported.

Test Plan

Create short and long filenames in a subdirectory on FAT12, 16, and 32
filesystems. Mount them with and without -o shortnames and verify that all
filenames are displayed correctly.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 20650.Sep 23 2016, 4:55 PM

asomers retitled this revision from to Mount msdosfs with longnames support by default..

asomers updated this object.

asomers edited the test plan for this revision. (Show Details)

asomers added reviewers: imp, trasz, adrian.

Herald added a reviewer: manpages. · View Herald TranscriptSep 23 2016, 4:55 PM

Add sys/sys/param.h to the review

Herald edited edge metadata. · View Herald TranscriptSep 23 2016, 4:59 PM

There's no reason not to support Win95 long file names ("LFN") by default. Long names are purely backwards compatible with shortname-only filesystems.

Pre-win95 Microsoft systems w/out LFN support can even mount and browse filesystems with LFN entries, due to the fallback 8.3 encoding. If they mount r/w and modify directories, they might destroy the LFN names, but I do not think this is our problem.

This revision is now accepted and ready to land.Sep 23 2016, 5:51 PM

wblock accepted this revision.Sep 23 2016, 6:02 PM

wblock added a reviewer: wblock.

Closed by commit rS306276: Mount msdosfs with longnames support by default. (authored by asomers). · Explain WhySep 23 2016, 7:05 PM

This revision was automatically updated to reflect the committed changes.