In D47169#1114112, @diizzy wrote:Submission to bugzilla is required for any policy defined my Porters Handbook to apply. I've asked this question before without getting any answer but do we have some kind of unified agreement that we're to accept PRs at all from GitHub from portmgr or people involved with ports?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Wed, Feb 5
Wed, Feb 5
do we have some kind of unified agreement that we're to accept PRs at all from GitHub from portmgr or people involved with ports?
Submission to bugzilla is required for any policy defined my Porters Handbook to apply. I've asked this question before without getting any answer but do we have some kind of unified agreement that we're to accept PRs at all from GitHub from portmgr or people involved with ports?
Mon, Feb 3
Mon, Feb 3
In D47169#1113528, @diizzy wrote:Actually this is incorrect, they NEED to be submitted on bugzilla for timeouts etc to apply
Actually this is incorrect, they NEED to be submitted on bugzilla for timeouts etc to apply
Fri, Jan 24
Fri, Jan 24
Wording and spelling LGTM, with or without jrm's suggestion. I'm not a ports committer either, so I can't speak beyond that.
For this change you will want to tag it with:
Reviewed by: fernape Approved by: fernape (ports) Approved by: mhorne (mentor)
Jan 18 2025
Jan 18 2025
Jan 17 2025
Jan 17 2025
LGTM
Dec 3 2024
Dec 3 2024
Oct 17 2024
Oct 17 2024
Aug 5 2024
Aug 5 2024
Another patch has been committed:
https://cgit.freebsd.org/ports/tree/www/newsraft
Mar 16 2024
Mar 16 2024
Has portlint, or similar, been run?
Mar 15 2024
Mar 15 2024
Has portlint, or similar, been run?
Update to 0.23.
Mar 13 2024
Mar 13 2024
poudriere-testport:
13.3-{amd64,i386}-release: OK
14.0-{amd64,i386}-release: OK
main-{amd64,i386}: OK
Feb 7 2024
Feb 7 2024
Already committed.
Feb 1 2024
Feb 1 2024
Jan 18 2024
Jan 18 2024
- Drop py-pip, it is not needed
- Improve DOC components
- Improve DOCS
- Include building the man page.
Add tests component
Fix Port tests component
Jan 14 2024
Jan 14 2024
In D43253#990385, @diizzy wrote:Poudriere reports:
Error: mail/py-flask-mailman depends on nonexistent origin 'textproc/py-mkdocs-include-markdown-plugin'; Please contact maintainer of the port to fix this.
Jan 13 2024
Jan 13 2024
Poudriere reports:
Error: mail/py-flask-mailman depends on nonexistent origin 'textproc/py-mkdocs-include-markdown-plugin'; Please contact maintainer of the port to fix this.
Jan 11 2024
Jan 11 2024
agh_riseup.net updated the diff for D42152: net-mgmt/py-pysnmplib: New Port, Pure Python SNMP library.
Update to 5.0.23
agh_riseup.net updated the diff for D42153: net-mgmt/py-pysnmp-lextudio: New Port, Pure Python SNMP library.
Update to 5.0.32
Jan 1 2024
Jan 1 2024
agh_riseup.net added a reviewer for D42152: net-mgmt/py-pysnmplib: New Port, Pure Python SNMP library: Ports Committers.
agh_riseup.net added a reviewer for D42878: www/newsraft: New port, TUI news feed aggregator: Ports Committers.
agh_riseup.net added a reviewer for D43180: textproc/py-sphinxcontrib-youtube: New port: Ports Committers.
agh_riseup.net added a reviewer for D43219: textproc/py-mkdocs-include-markdown-plugin: New Port: Ports Committers.
Dec 31 2023
Dec 31 2023
In D42068#985819, @rene wrote:In D42068#985744, @jbeich wrote:Before landing it'd be nice to turn off 12.4 package builders. Otherwise, /latest and /quarterly will become empty while /release_* still work. The space can be later reclaimed by consistently removing all sets and removing FreeBSD:12:* references on https://pkg.freebsd.org/
This cleanup only affects main, not quarterly/2023Q4. There is a 12-eol tag on main so the pkg builders could stick to that?
On a different note jbeich is somewhat correct. If the builders were still started it would end up with an empty pkgset and the cluster pkgset would overwrite the pkg repos with an empty set being served. Although not exactly sure on how the builders are run so we disabled the pkgsync script and backed it up and have removed the pkgsets.
In D43253#985836, @minsoochoo0122_proton.me wrote:In D43253#985801, @agh_riseup.net wrote:In D43253#985787, @minsoochoo0122_proton.me wrote:Please add ports group to reviewers, subscribers, and tag otherwise people won't be notified.
I have no idea what that entails. If I Edit Revision via the menu box at the top right, I can find the three fields you mention, however, when I type ports, a number of options are auto populated in a drop down list, none of which are ports.
Is this meant to be standard procedure too?Try Contributor Reviewers (ports)
In D42068#985744, @jbeich wrote:Before landing it'd be nice to turn off 12.4 package builders. Otherwise, /latest and /quarterly will become empty while /release_* still work. The space can be later reclaimed by consistently removing all sets and removing FreeBSD:12:* references on https://pkg.freebsd.org/
Before landing it'd be nice to turn off 12.4 package builders. Otherwise, /latest and /quarterly will become empty while /release_* still work. The space can be later reclaimed by consistently removing all sets and removing FreeBSD:12:* references on https://pkg.freebsd.org/
Dec 30 2023
Dec 30 2023
In D42068#985549, @jbeich wrote:Many patches for missing <byteswap.h> and <endian.h> on FreeBSD < 13 can probably be dropped e.g.,
Many patches for missing <byteswap.h> and <endian.h> on FreeBSD < 13 can probably be dropped e.g.,
- audio/bespokesynth/files/patch-libs_link_include_ableton_platforms_linux_Linux.hpp
- audio/mixxx/files/patch-lib_kaitai_kaitaistream.cpp
- audio/umurmur/Makefile (BROKEN_*)
- audio/umurmur/files/patch-src_byteorder.h
- audio/webrtc-audio-processing/files/patch-powerpc64 (keep <altivec.h> part)
- audio/zita-alsa-pcmi/files/patch-source_zita-alsa-pcmi.cc
- biology/abyss/files/patch-Common_city.cc
- databases/redisdesktopmanager/files/patch-3rdparty_simdjson_singleheader_simdjson.h
- devel/chrpath/files/patch-protos.h (keep Elf_Ehdr part)
- devel/cityhash/files/patch-src_city.cc
- devel/dwarves/files/patch-lib_bpf_src_btf.c (the first 3 hunks, keep from compare_vsi_off onwards)
- devel/efivar/files/patch-src-efivar.h (keep __builtin_* part)
- devel/elfutils/files/patch-lib_byteswap.h
- devel/firmware-utils/files/patch-* (<endian.h> part, keep `"freebsd.h")
- devel/py-pysimdjson/files/patch-simdjson_simdjson.h
- graphics/igt-gpu-tools/files/patch-lib_igt_\_core.h (keep <signal.h> part)
- graphics/libemf/files/patch-libemf_libemf.cpp
- multimedia/dvb-apps/files/patch-lib_libucsi_endianops.h
- multimedia/ringrtc/files/patch-src_webrtc_src_rtc_\_base_byte_\_order.h
- multimedia/smpeg/files/patch-video_\_video.h
- net/mercury/Makefile (BROKEN)
- net/yate/files/patch-libs_yradio_radio.cpp
- security/pam_pwdfile/files/patch-md5.c
- sysutils/afflib/files/patch-lib_qemu_bswap.h
- sysutils/dd_rescue/files/patch-aes_\_c.c
- sysutils/lttng-tools/files/patch-src_bin_lttng-crash_lttng-crash.c
- sysutils/lttng-tools/files/patch-src_common_compat_endian.h
- sysutils/zbackup/files/patch-compression.cc
- sysutils/zbackup/files/patch-endian.hh
- www/envoy/files/patch-envoy_common_platform.h (keep ENVOY_MMSG_MORE part)
- www/mod_gnutls/files/patch-src_gnutls_\_sni.c
- www/qt5-webengine/files/patch-src_3rdparty_chromium_third_\_party_smhasher_src_City.cpp
Dec 23 2023
Dec 23 2023
Latest rebase and most probably the last one before the sunset.
Dec 13 2023
Dec 13 2023
Dec 12 2023
Dec 12 2023
More changes by @jbeich
In D42068#980655, @jbeich wrote:In D42068#980602, @bofh wrote:These are still not fixed. I've also noticed more cruft:
- devel/libffcall/files/patch-ffcall-abi.h
I think this patch is not related to sparc but aarch64.
aarch64 (arm64) has 2 "a" in the architecture name. sparc64 (64-bit sparc, or sparc V9) may not define __sparc64__ on non-BSDs thus required checking both __sparc__ and __arch64__.
Add more changes by @jbeich
In D42068#980602, @bofh wrote:These are still not fixed. I've also noticed more cruft:
- devel/libffcall/files/patch-ffcall-abi.h
I think this patch is not related to sparc but aarch64.
These are still not fixed. I've also noticed more cruft:
- devel/libffcall/files/patch-ffcall-abi.h
I think this patch is not related to sparc but aarch64.
In D42068#980467, @jbeich wrote:
- shells/v7sh/files/Makefile (only ${OSREL:R} < 13)
- www/tor-browser/files/patch-third_\_party_libwebrtc_rtc_\_base_ip_\_address.cc
Update as per @jhale
Dec 11 2023
Dec 11 2023
Missed cruft (based on 2023-12-11 checkout):
- lang/emilua/Makefile (only IGNORE_FreeBSD_12)
- lang/go-devel/Makefile (only ${OSREL:R} < 13)
- lang/mlton/Makefile (keep ${OSREL:R} >= 13 but make unconditional)
- mail/fetchmail/Makefile (only ${OSREL:R} < 13)
- net/widentd/Makefile (only ${OSREL:R} < 13)
- shells/v7sh/files/Makefile (only ${OSREL:R} < 13)
- sysutils/plasma5-powerdevil/files/patch-daemon_backends_upower_freebsdbacklighthelper.cpp
- www/tor-browser/files/patch-third_\_party_libwebrtc_rtc_\_base_ip_\_address.cc
Rebase and add some changes as per @jbeich
Thanks @jbeich . I will look into it and refresh the patch.
Missed cruft (based on 2023-10-14 checkout):
- audio/opus/Makefile (only arm conditional)
- cad/nvc/Makefile (only !exists(/usr/include/unwind.h) conditional)
- comms/ebusd/files/patch-src_lib_ebus_datatype.cpp
- devel/android-tools/files/patch-vendor_adb_compression_\_utils.h
- devel/llvm1[2-3]/Makefile (only unwind.h-related _BUILD_DEPENDS, _USES, inline comments)
- emulators/rpcs3/files/patch-libc++13
- graphics/darktable/Makefile (only ${OPSYS}_${OSREL:R} == FreeBSD_12 conditional)
- graphics/krita/files/patch-cmake_modules_xsimd_xsimdMacros.cmake
- graphics/qt5-wayland/files/patch-src_client_qwaylandshmbackingstore.cpp (only && __FreeBSD_version >= 1300048 part)
- java/openjdk*/Makefile (only ${OSREL:C/\.[0-9]//} == 12 conditional and the related patch)
- mail/thunderbird/files/patch-third_\_party_libwebrtc_rtc_\_base_ip_\_address.cc
- multimedia/dav1d/files/patch-freebsd12
- multimedia/pipewire/files/patch-src_modules_module-netjack2_peer.c
- net-im/libquotient/files/patch-Quotient_qt_\_connection_\_util.h
- net/samba413/Makefile (only ${OSVERSION} < 1300000 conditional)
- sysutils/arcconf/Makefile (only ${OSREL:R} == 12 part)
- www/chromium/files/patch-third_\_party_wayland_include_config.h (only memfd part)
- www/chromium/files/patch-ui_ozone_platform_wayland_host_zwp_\_text_\_input_\_wrapper_\_v1.cc
- Ditto (as www/chromium) in devel/electron*, www/iridium, www/ungoogled-chromium
- www/librewolf/files/patch-third_\_party_libwebrtc_rtc_\_base_ip_\_address.cc
- x11/xdg-desktop-portal-luminous/Makefile (only BROKEN_FreeBSD_12)
Dec 6 2023
Dec 6 2023
BROKEN_FreeBSD12 in www/ladybird can be removed too
Nov 24 2023
Nov 24 2023
Nov 1 2023
Nov 1 2023
https://cgit.FreeBSD.org/ports/commit/?id=0815295e0b7988daf05dc1665b4ff523c7083763 can be reverted too as part of this change
Oct 29 2023
Oct 29 2023
Oct 19 2023
Oct 19 2023
Oct 15 2023
Oct 15 2023
Update some of the files based on the review from @rene
www/firefox/files/patch-third__party_libwebrtc_rtc__base_ip__address.cc
and
www/firefox-esr/files/patch-third__party_libwebrtc_rtc__base_ip__address.cc
are also obsolete after 12-EOL
Oct 5 2023
Oct 5 2023
Changes are fine as such for devel/llvm* although devel/llvm17 is missing the Sparc backend removal. I think it's OK to not bump port revision here as the FreeBSD backends are a non-default configuration.
In D42068#960015, @salvadore wrote:In https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273397 I have requested an exp-run that found errors that seem to apply to FreeBSD 12 only. Do you suggest that I request a new exp-run on FreeBSD 13 and ignore all FreeBSD 12 specific issues? And maybe also wait for FreeBSD 12 official EOL to commit the final patch?
Do you have a plan to merge this into quarterly? If not then I would say forget 12 related patches in your fixes. Additionally I saw your patch and some of the fallouts. I forgot the bug which you assigned to me but so far I found that the fallout reasons are due to an issue with GCC13 which was fixed in the most recent version of GCC13.
I approve as far as the ports that I maintain (GCC ports from 10 to 14) are concerned.
Oct 4 2023
Oct 4 2023
bofh added reviewers for D42068: */*: Sunset 12.4-RELEASE/12-STABLE from ports tree: brooks, salvadore.
Aug 3 2023
Aug 3 2023
Dec 3 2022
Dec 3 2022
Apr 19 2022
Apr 19 2022
Feb 9 2022
Feb 9 2022
Jan 10 2022
Jan 10 2022
Dec 15 2021
Dec 15 2021
Dec 14 2021
Dec 14 2021
Patch committed. Thanks for your contribution!
Thank you @tagattie !
Thanks for the head up and sorry for getting back this late.