Newsraft is a feed reader with a ncurses user interface. It is greatly
inspired by Newsboat, and aims to be a lightweight alternative.
Details
- Reviewers
- None
- Group Reviewers
Ports Committers
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Update to 0.23.
poudriere-testport:
13.3-{amd64,i386}-release: OK
14.0-{amd64,i386}-release: OK
main-{amd64,i386}: OK
Has portlint, or similar, been run?
Overall, looks good to me with just a couple of small points.
www/newsraft/Makefile | ||
---|---|---|
21 | Very minor, but it looks like there's an extra space on this line before CC. | |
www/newsraft/files/patch-makefile | ||
1 | These look like very reasonable changes that could be upstreamed. Have you tried opening a pull request with these changes to see if they are receptive? |
Has portlint, or similar, been run?
Yes.
$ portlint -ANt . looks fine.
$ portclippy --strict Makefile (0)
$ portfmt -D -t Makefile (0)
Overall, looks good to me with just a couple of small points.
Thanks for the comments.
www/newsraft/Makefile | ||
---|---|---|
21 | Yeah it does look like some unwanted noise. I checked the working directory, the git formatted-patch in my editor (cursor jumps thru a tab character, editor renders tabs too), and ran linters again, there is no extra space, perhaps a Phabricator anomaly? | |
www/newsraft/files/patch-makefile | ||
1 | I will investigate this. |
www/newsraft/Makefile | ||
---|---|---|
21 | Also confirmed in ${EDITOR} that the = used on lines 20, and 21 are ASCII 0x3d, followed by 0x09 for horizontal tab, followed by the respective alpha characters, 0x6d (m(...akefile)), and 0x43 (C(...C="${CC}")). |