- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 2 2020
Dec 19 2019
In D22870#500744, @markj wrote:IMO it makes slightly more sense to have the check in the ixl ioctl handler: it serves as a signal to anyone extending the ioctl handler that they should be careful, and doing so maintains the invariant that internal driver functions need not check for privileges. I am not the maintainer though so I don't insist on any particular approach.
Dec 3 2019
Dec 2 2019
In D22523#495057, @jacob.e.keller_intel.com wrote:Hmm. I think I understand the change.. but it seems less intuitive.
Do you have any example of how much this improves? I.e. a C program with a large enough test case to show measurable improvement?
Nov 21 2019
Nov 5 2019
Builds okay now.
Nov 4 2019
Don't remove the extra whitespace in if.c
Update patch to make it build on HEAD
I get a build error with this revision:
Adding @jpaetzel since he seemed to be the last person making updates to oce(4); is this change ok to make there? There's no functional change.
@jacob.e.keller_intel.com, is this ready to be committed?
Oct 30 2019
Oct 23 2019
Update review with a first cut version of the code that checks the bus
ranges of upstream pci bridges; this doesn't incorporate suggestions
that jhb@ had made.
Oct 21 2019
- Add a specific iflib flag for VLAN anti-spoof and use it
Oct 18 2019
Resolve merge conflict
Oct 16 2019
Oct 15 2019
Oct 10 2019
Oct 9 2019
Oct 8 2019
Here's the output I got from the first pcib above ice4/ice5 in devinfo:
I like the changes for the Intel ethernet drivers. I've always been uncomfortable with how we were required to manually iterate through the list in the driver using the LIST_FOREACH macros; like you say in your description, if the data structure changes, then it causes a lot of driver thrash.
In D21944#479344, @jhb wrote:How did this work? Meaning how did you allocate bus numbers? Did the parent PCI-PCI bridge have enough bus numbers in range already? For this to work properly you'd need to ensure that the parent PCI-PCI bridge at the other end of the link has the requested bus numbers mapped into its range of valid bus numbers.
@krzysztof.galazka_intel.com did this get tested yet?
In D21712#474097, @gallatin wrote:Would it make sense then to assert that the link is down?
Oct 4 2019
Sep 30 2019
Relevant bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240610
Bugzilla link: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240610
Sep 24 2019
Sep 17 2019
Sep 16 2019
Sep 9 2019
Is there a reason that we wouldn't do this for all of our drivers, instead of hardcoding the BAR index?