Differential D21041

net: Update SFF-8024 definitions and strings with values from rev 4.6
ClosedPublic
Actions

Authored by erj on Jul 23 2019, 8:45 PM.

Tags

Referenced Files

	F158580099: D21041.diff
	Wed, Jun 3, 2:02 PM

	Unknown Object (File)
	Sun, May 31, 3:02 PM

	Unknown Object (File)
	Fri, May 29, 4:26 AM

	Unknown Object (File)
	Wed, May 20, 8:56 PM

	Unknown Object (File)
	Fri, May 15, 4:20 AM

	Unknown Object (File)
	Fri, May 15, 3:16 AM

	Unknown Object (File)
	Thu, May 14, 11:04 AM

	Unknown Object (File)
	May 1 2026, 12:27 PM

Subscribers

Intel Networking

Details

Reviewers

• hselasky
melifaro
jhb
np
slavash
gallatin

Commits

rS351153: net: Update SFF-8024 definitions and strings with values from rev 4.6

Summary

This will let ifconfig -v's SFF eeprom read functionality recognize more
module types.

Signed-off-by: Eric Joyner <erj@freebsd.org>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

erj created this revision.Jul 23 2019, 8:45 PM

Herald added a subscriber: ae. · View Herald TranscriptJul 23 2019, 8:45 PM

Harbormaster completed remote builds in B25473: Diff 60060.Jul 23 2019, 8:45 PM

erj added reviewers: • hselasky, melifaro, jhb, np.Jul 24 2019, 4:23 PM

erj set the repository for this revision to rS FreeBSD src repository - subversion.

erj added a project: network.

Herald added a subscriber: imp. · View Herald TranscriptJul 24 2019, 4:23 PM

• hselasky added reviewers: slavash, gallatin.Jul 24 2019, 4:28 PM

erj added inline comments.Jul 24 2019, 4:29 PM

sys/net/sff8472.h
435 ↗	(On Diff #60060)	Are these strings not allowed to have spaces? It would be useful for this entry (at least) to say "QSFP+ or later" instead -- we do have QSFP28 cables that have an 0xD ID instead of 0x11.

gallatin accepted this revision.Jul 24 2019, 8:51 PM

This revision is now accepted and ready to land.Jul 24 2019, 8:51 PM

Closed by commit rS351153: net: Update SFF-8024 definitions and strings with values from rev 4.6 (authored by erj). · Explain WhyAug 17 2019, 12:11 AM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rS351153: net: Update SFF-8024 definitions and strings with values from rev 4.6.

Revision Contents
Changeset List

Path

Size

head/

sbin/

ifconfig/

69 lines

sys/

net/

77 lines

Diff 60923

head/sbin/ifconfig/sfp.c

Loading...

head/sys/net/sff8472.h

Loading...