Page MenuHomeFreeBSD

ix: report isc_pause_frames during stat update
ClosedPublic

Authored by jacob.e.keller_intel.com on Oct 1 2019, 11:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 11:56 AM
Unknown Object (File)
Sun, Feb 9, 2:19 AM
Unknown Object (File)
Sat, Feb 8, 12:21 PM
Unknown Object (File)
Fri, Feb 7, 5:27 AM
Unknown Object (File)
Sat, Feb 1, 6:54 PM
Unknown Object (File)
Fri, Jan 31, 9:53 AM
Unknown Object (File)
Dec 15 2024, 3:51 PM
Unknown Object (File)
Dec 12 2024, 7:32 PM
Subscribers

Details

Summary

Notify the iflib stack of whether we received any pause frames during
the timer window. This allows the stack to avoid reporting a Tx hang due
to the device being paused.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gallatin added inline comments.
sys/dev/ixgbe/if_ix.c
1462 ↗(On Diff #62815)

this comes from IXGBE_LXOFFTXC.. Isn't that a counter of the pause frames that we have sent? I would think you'd want to use IXGBE_LXOFFRXC, which I think counts the pause frames we've received..?

sys/dev/ixgbe/if_ix.c
1462 ↗(On Diff #62815)

Yea, I think you're right.

Use the correct register value for the received pause frames

This revision is now accepted and ready to land.Oct 9 2019, 8:46 PM
This revision was automatically updated to reflect the committed changes.