Page MenuHomeFreeBSD

ix: report isc_pause_frames during stat update
ClosedPublic

Authored by jacob.e.keller_intel.com on Tue, Oct 1, 11:44 PM.

Details

Summary

Notify the iflib stack of whether we received any pause frames during
the timer window. This allows the stack to avoid reporting a Tx hang due
to the device being paused.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erj set the repository for this revision to rS FreeBSD src repository.
gallatin added inline comments.
sys/dev/ixgbe/if_ix.c
1462 ↗(On Diff #62815)

this comes from IXGBE_LXOFFTXC.. Isn't that a counter of the pause frames that we have sent? I would think you'd want to use IXGBE_LXOFFRXC, which I think counts the pause frames we've received..?

sys/dev/ixgbe/if_ix.c
1462 ↗(On Diff #62815)

Yea, I think you're right.

Use the correct register value for the received pause frames

gallatin accepted this revision.Wed, Oct 9, 8:46 PM
This revision is now accepted and ready to land.Wed, Oct 9, 8:46 PM
This revision was automatically updated to reflect the committed changes.