Differential D11378
iWARP driver for Intel X722 Adapter - initial commit Authored by pkubaj on Jun 27 2017, 11:42 AM. Tags None Referenced Files
Details
This is an initial commit for iWARP FreeBSD driver for Intel(R) Ethernet Connection X722. This module is considered a BETA quality release. Testing has been done using krping tool, as well as some additional internal test tools that exercise Kernel Verbs API.
Diff Detail
Event TimelineComment Actions Known Issues:
Comment Actions This doesn't appear to be connected to the kernel build via sys/conf/files. It also does not have a kernel config option via sys/conf/options. Comment Actions Missing a man page. Probably needs something for share/man/man4. Maybe an iw_ixl(4) page? Comment Actions I should add that we're going to update the ixl(4) driver soon because as @bartosz.sobczak_intel.com mentioned, it will fix a crash. Comment Actions This is a Beta release, so, first of all, i do not want the driver to be loaded with the kernel at startup (especially before if_ixl would be updated to 1.7.13 or later). Again, this is a Beta stage release. I think it would be best to build it only when it is needed, for people who want to use it, especially that there are some additional settings that needs to be inserted into kernel configuration for it to work (the OFED, and proper settings of the ixl driver). For both of these issues I'd leave it as is for now, and consider further integration with the kernel in the future. Actually, i have a man page ready for submission, I thought it would be a good idea to add it later. Do you think it would be better to post it in this commit? Thanks for your input! Comment Actions We have a WITH_OFED knob for all the OFED components -- RDMA infrastructure and hardware drivers. iw_ixl could Comment Actions Adding the module for compilation with buildkernel. Additional files modified:
Comment Actions Changes suggested by wblock are applied. Comment Actions I don't think these are very significant, but I get the following warnings during a build: /home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_utils.c:943:46: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
i40iw_copy_ip_ntohl(loc_addr, (__be32 *) & ip6h->ip6_dst);
^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_utils.c:944:46: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
i40iw_copy_ip_ntohl(rem_addr, (__be32 *) & ip6h->ip6_src);
^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:488:36: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
i40iw_copy_ip_htonl((__be32 *) & ip6h->ip6_src,
^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:490:36: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
i40iw_copy_ip_htonl((__be32 *) & ip6h->ip6_dst,
^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:3046:22: warning: taking address of packed member 'ip6_dst' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
(__be32 *) & ip6h->ip6_dst);
^~~~~~~~~~~~~
/home/sbruno/bsd/fbsd_head/sys/modules/ixl/iw_ixl/../../../dev/ixl/iwarp/iw_ixl_cm.c:3048:22: warning: taking address of packed member 'ip6_src' of class or structure 'ip6_hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
(__be32 *) & ip6h->ip6_src);Comment Actions Indeed, I don't find it too significant. I guess this is just a performance issue, which is insignificant given the amount of times this operation is done. And what is more important, this is related to the path which would be exercised only when using ipv6. The ipv6 is currently not supported, and there are some changes to the OFED going to be needed to make it work. Comment Actions @sbruno - I think Bartosz needed an update to the in-kernel ixl(4) for this to work properly. @bartosz.sobczak_intel.com - I'm still working on fixing a critical SW6 bug; I need to get that fixed before I upstream the updated ixl(4) driver. I'm sorry for the delay, but it's difficult to debug. Comment Actions Also, this is incredibly minor, but the space between the "&" and variable names in the function arguments really bothers me, visually. Comment Actions Removing additional errors in READMEs. Comment Actions @erj are you going to commit this once you've made the IXL updates required for it to function? Comment Actions Yeah, that's the plan. If @bartosz.sobczak_intel.com is okay with the current version. Comment Actions This will collide with the the projects/bsd_rdma_4_9 branch. Have you looked at that? See this message too: Comment Actions Thanks for warning! Comment Actions Several changes have been done to the driver code:
Please note, that this code is designed as a way to distribute the driver also for older systems, thus some ifdefs checking OS version are present. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||