In rare situations, this might cause 2 times a root_hold_delay: if devices that need fsck appear later and other devices for mountcritlocal appear even later. I suppose it is not a major issue. Fixing it would probably require giving up the separation of fsck and mountcritlocal.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 5 2016
May 3 2016
OK for the bin/sh/parser.c change.
Apr 30 2016
This may lead to somewhat ugly messages like
-/bin/sh: Syntax error: ")" unexpected
for newgrp -l (where -sh: used to appear) but I think newgrp is not used often enough to warrant making this more complicated.
Apr 29 2016
Apr 25 2016
In D5977#129534, @kristof wrote:In D5977#129496, @jilles wrote:This is good because it looks like it will at least prevent the panic, but it may not make the files accessible since there need not be a short name. Adding a comment may be appropriate.
It's my understanding that there should always be a short filename (to keep the fs usable as a plain fat fs). I've deliberately chosen to use that one instead of truncating the name (as netbsd does) to avoid getting in the situation where two directory entries have the same (truncated) name.
Apr 24 2016
This is good because it looks like it will at least prevent the panic, but it may not make the files accessible since there need not be a short name. Adding a comment may be appropriate.
I think the idea of sourcing the rc.d script is good but the implementation here has some issues.
Apr 17 2016
Apr 16 2016
Apr 13 2016
Apr 10 2016
Apr 9 2016
Apr 8 2016
Mar 29 2016
Looks good to me (but probably avoid MFC).
Mar 28 2016
Mar 27 2016
Mar 13 2016
Mar 12 2016
Mar 11 2016
Mar 9 2016
Mar 7 2016
Mar 6 2016
Mar 2 2016
Feb 29 2016
Feb 23 2016
Feb 21 2016
Feb 19 2016
Feb 11 2016
Feb 7 2016
Jan 30 2016
Jan 27 2016
Jan 24 2016
Jan 23 2016
Jan 22 2016
Jan 21 2016
Jan 19 2016
Looks good to me.
Jan 17 2016
Jan 15 2016
This adds a requirement that the test be run as root and that securelevel be -1 or 0, which may not be desirable. To prevent compatibility problems, a line
TEST_METADATA.truncate_test+= required_user="root"
should be added to usr.bin/truncate/tests/Makefile.
Jan 12 2016
Jan 10 2016
Jan 7 2016
Jan 5 2016
Jan 3 2016
Dec 31 2015
Dec 29 2015
Dec 28 2015
Dec 27 2015
Dec 26 2015
Looks good to me.
Dec 23 2015
Dec 22 2015
In D4412#98339, @ed wrote:Done! I think that for now it makes sense to pick the following middle ground:
- Let the tests use nrand48().
- Initialize the random state with arc4random_buf().
This means that we still have the advantage of not fixing the test to a single sequence (which may not provide full coverage), but still allow for changing the test to use a fixed sequence in case we want to narrow down problems. Is this acceptable?
Dec 21 2015
In D4412#97602, @ed wrote:In D4412#97496, @jilles wrote:A deterministic random number generator may be more useful for the test, so that runs can be reproduced.
Looks good to me otherwise.
Which random number generator do you suggest should be used in this case? Are *rand48() good for this purpose?
Dec 20 2015
Dec 18 2015
A deterministic random number generator may be more useful for the test, so that runs can be reproduced.
Dec 16 2015
Dec 12 2015
Dec 6 2015
I noticed two unexpected return -1. They are not a memory leak but inconsistent.
Dec 5 2015
Dec 4 2015
Nov 27 2015
I tried various locales and the output looks good to me. I found one minor nit in the code.