Fix leak in mkfs_msdos(..)
ClosedPublic
Actions

Authored by ngie on Dec 6 2015, 12:14 AM.

Details

Reviewers

emaste
jilles

Summary

Fix leak in mkfs_msdos(..) by initializing img to NULL and free'ing at the end
of the function

PR: 204943
MFC after: 1 week
Reported by: David Binderman <dcb314@hotmail.com>
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1456
Build 1461: arc lint + arc unit

Event Timeline

ngie updated this revision to Diff 10804.Dec 6 2015, 12:14 AM

ngie retitled this revision from to Fix leak in mkfs_msdos(..).

ngie updated this object.

ngie added a reviewer: emaste.

ngie added a subscriber: jilles.

Herald added a subscriber: imp. · View Herald TranscriptDec 6 2015, 12:14 AM

I noticed two unexpected return -1. They are not a memory leak but inconsistent.

It looks good otherwise.

sbin/newfs_msdos/mkfs_msdos.c
290	Why is there no `goto done` here?
298	and here?

This revision now requires changes to proceed.Dec 6 2015, 1:24 PM

Add a couple missing goto dones spotted by jilles

Fixed the accidental oversights -- thanks :).

jilles accepted this revision.Dec 6 2015, 8:11 PM

jilles edited edge metadata.

This revision is now accepted and ready to land.Dec 6 2015, 8:11 PM

Can you notify Christos as well in the hope that NetBSD will apply an equivalent change?

ngie closed this revision.Dec 9 2015, 2:03 AM

Revision Contents
Changeset List

Path

Size

sbin/

newfs_msdos/

mkfs_msdos.c

87 lines

Diff 10827

View Options

sbin/newfs_msdos/mkfs_msdos.c

Fix leak in mkfs_msdos(..)ClosedPublicActions