Page MenuHomeFreeBSD

Fix usr.bin.truncate.truncate_test.bad_truncate with ZFS /tmp.
ClosedPublic

Authored by asomers on Jan 11 2016, 9:37 PM.
Tags
None
Referenced Files
F103361498: D4862.diff
Sun, Nov 24, 1:16 AM
Unknown Object (File)
Thu, Nov 21, 10:23 AM
Unknown Object (File)
Sun, Nov 17, 6:46 AM
Unknown Object (File)
Mon, Nov 11, 2:22 PM
Unknown Object (File)
Mon, Nov 11, 7:32 AM
Unknown Object (File)
Mon, Nov 11, 5:41 AM
Unknown Object (File)
Thu, Oct 31, 10:01 PM
Unknown Object (File)
Oct 7 2024, 9:44 PM
Subscribers

Details

Summary

Use simmutable instead of uimmutable in the bad_truncate test. The former
is supported by both ZFS and UFS, but the latter only by UFS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers retitled this revision from to Fix usr.bin.truncate.truncate_test.bad_truncate with ZFS /tmp..
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: jilles.

This adds a requirement that the test be run as root and that securelevel be -1 or 0, which may not be desirable. To prevent compatibility problems, a line

TEST_METADATA.truncate_test+=  required_user="root"

should be added to usr.bin/truncate/tests/Makefile.

Alternatively, file permissions (chmod 444) instead of file flags could be used. This requires

TEST_METADATA.truncate_test+=  required_user="unprivileged"

and the expected error message should be Permission denied instead of Operation not permitted.

asomers edited edge metadata.

Address feedback from jilles: Use permissions instead of flags in bad_truncate

jilles edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jan 19 2016, 10:02 PM
This revision was automatically updated to reflect the committed changes.