fsck.
ClosedPublic
Actions

Authored by trasz on May 5 2016, 11:53 AM.

Details

Reviewers

Commits

rS299349: Refactor the root mount hold code and add the wait to etc/rc.d/fsck.

Summary

Refactor the root mount hold code and add the wait to etc/rc.d/fsck.
This fixes mounting (non-root) USB drives on boot with fsck enabled
(with non-zero 'Pass#' field in fstab(5).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz updated this revision to Diff 15925.May 5 2016, 11:53 AM

trasz retitled this revision from to Wait for root mount hold release in etc/rc.d/fsck..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptMay 5 2016, 11:53 AM

trasz added a reviewer: jilles.May 5 2016, 11:54 AM

In rare situations, this might cause 2 times a root_hold_delay: if devices that need fsck appear later and other devices for mountcritlocal appear even later. I suppose it is not a major issue. Fixing it would probably require giving up the separation of fsck and mountcritlocal.

etc/rc.subr
1962 ↗	(On Diff #15925)	This comment needs to be updated for its new location. "This script" can be mountcritlocal or fsck now. The last sentence likewise needs adjustment.

Hm, it shouldn't work that way - releasing the root mount hold happens only once; plugging eg an USB disk doesn't affect it. Also, the root_hold_delay is "just in case" - if something hits the timeout, it probably means trouble at the kernel level.