Page MenuHomeFreeBSD

Check for running daemons before a custom start_cmd is executed
ClosedPublic

Authored by erdgeist_erdgeist.org on Nov 14 2015, 10:21 PM.
Tags
None
Referenced Files
F132070738: D4156.id.diff
Mon, Oct 13, 9:56 AM
F132070729: D4156.id10744.diff
Mon, Oct 13, 9:56 AM
F132070724: D4156.id10179.diff
Mon, Oct 13, 9:56 AM
Unknown Object (File)
Sun, Oct 12, 9:26 PM
Unknown Object (File)
Mon, Oct 6, 2:17 AM
Unknown Object (File)
Fri, Sep 19, 6:09 AM
Unknown Object (File)
Aug 13 2025, 6:04 AM
Unknown Object (File)
Aug 8 2025, 7:56 PM
Subscribers

Details

Summary

Currently rc scripts implementing their own start_cmd do not enjoy the benefits of rc.subr's own check for rc_pid.

This leads to around a third of ports with such a start_cmd not to check for the process at all and two thirds of ports to re-implement this check (sometimes wrongly).

This patch moves the check for rc_pid to before ${rc_arg}_cmd is executed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

erdgeist_erdgeist.org retitled this revision from to Check or running daemons before a custom start_cmd is executed.
erdgeist_erdgeist.org updated this object.
erdgeist_erdgeist.org edited the test plan for this revision. (Show Details)
erdgeist_erdgeist.org added reviewers: feld, jilles.
erdgeist_erdgeist.org set the repository for this revision to rS FreeBSD src repository - subversion.
erdgeist_erdgeist.org retitled this revision from Check or running daemons before a custom start_cmd is executed to Check for running daemons before a custom start_cmd is executed.Nov 14 2015, 10:44 PM
jilles edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2015, 2:37 PM
feld edited edge metadata.

This solves an annoyance for me. Thanks for doing this!

This revision was automatically updated to reflect the committed changes.