Page MenuHomeFreeBSD
Feed Advanced Search

Sep 30 2024

zlei committed rGbfcaaff418b8: sound: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
sound: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG025c47549419: pms(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
pms(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG3e51da349563: mrsas(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
mrsas(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rGae8388f726b5: mpi3mr(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
mpi3mr(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG4fee8d3e92c6: mfi(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
mfi(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rGcf44738feb83: mlx(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
mlx(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG0fa85665105b: mana: Stop checking for failures from malloc/mallocarray/buf_ring_alloc… (authored by zlei).
mana: Stop checking for failures from malloc/mallocarray/buf_ring_alloc…
Sep 30 2024, 4:46 AM
zlei committed rGec68da0a7e6e: iser(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
iser(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGbb8c6f43256d: ice(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
ice(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGe4de0a965faa: hptrr(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
hptrr(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGc860df902b6d: hptnr(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
hptnr(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG0341c77f203e: hpt27xx(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
hpt27xx(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGf3af52726024: fwip(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
fwip(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG6515ef4d2b42: flexspi: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
flexspi: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGe78c315e8941: etherswitch: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
etherswitch: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG8c2d777a223d: ena(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
ena(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG09ed34449c79: cxgbe(4): Stop checking for failures from malloc/mb_alloc_ext_pgs(M_WAITOK) (authored by zlei).
cxgbe(4): Stop checking for failures from malloc/mb_alloc_ext_pgs(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG95532d15a12c: drm2: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
drm2: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG9216ba1853b7: cxgb(4): Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK) (authored by zlei).
cxgb(4): Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG3db5be682169: axgbe: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
axgbe: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGe763c326fc85: bnxt(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
bnxt(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG8c2748b922f5: ath(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
ath(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG66bb507ccb1c: altera: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
altera: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG74887e322101: al_eth: Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK) (authored by zlei).
al_eth: Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG49995f771b53: smmu: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
smmu: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG53b79271160c: cmn600: Stop checking for failures from malloc/mallocarray(M_WAITOK) (authored by zlei).
cmn600: Stop checking for failures from malloc/mallocarray(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG6a0ed6fe27ec: tests: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
tests: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG920288c32900: arm ti: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
arm ti: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG7bea79c1ab40: LinuxKPI: 802.11: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
LinuxKPI: 802.11: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG905d5420ee1e: krping: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
krping: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG3d5e539b1f43: xdr: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
xdr: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGce708880847c: netsmb: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
netsmb: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGa0c4498478f9: pf: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
pf: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG67971181687f: if_vlan: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
if_vlan: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rG891fdd020a68: altq: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
altq: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:46 AM
zlei committed rGa77e68b0148d: udf: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
udf: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:45 AM
zlei committed rGd2d4758456aa: ctl: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
ctl: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:45 AM
zlei committed rG44a6f9c9a0b5: subr_bus: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
subr_bus: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:45 AM
zlei committed rGfbaf48065115: kern_fail: Stop checking for failures from fp_malloc(M_WAITOK) (authored by zlei).
kern_fail: Stop checking for failures from fp_malloc(M_WAITOK)
Sep 30 2024, 4:45 AM
zlei committed rGab314540193e: boottrace: Stop checking for failures from realloc(M_WAITOK) (authored by zlei).
boottrace: Stop checking for failures from realloc(M_WAITOK)
Sep 30 2024, 4:45 AM

Sep 29 2024

zlei added inline comments to D46821: sound: Move root feeder initialization to separate function.
Sep 29 2024, 3:16 PM
zlei accepted D46844: sound: Do not cast return value of malloc(9).

Looks good to me.

Sep 29 2024, 2:31 PM
zlei accepted D46845: sound: Use M_WAITOK where possible.

Looks good to me.

Sep 29 2024, 2:29 PM
zlei accepted D46821: sound: Move root feeder initialization to separate function.
Sep 29 2024, 3:15 AM
zlei accepted D46749: sound: Move global variable initialization to sound_modevent().

Looks good to me.

Sep 29 2024, 3:02 AM

Sep 26 2024

zlei committed rGbf154c499e84: iflib: Many style fixes (authored by zlei).
iflib: Many style fixes
Sep 26 2024, 10:03 AM
zlei committed rGe67e19325287: iflib: Prefer C99's __func__ over GCC's __FUNCTION__ (authored by zlei).
iflib: Prefer C99's __func__ over GCC's __FUNCTION__
Sep 26 2024, 10:02 AM
zlei added a comment to D45727: bpf: Detach descriptors on interface departure event.

Any comment on this ?

Sep 26 2024, 8:50 AM
zlei added inline comments to D46794: axgbe: Fix setting promisc mode.
Sep 26 2024, 8:47 AM
zlei added a comment to D46794: axgbe: Fix setting promisc mode.

I do not have axgbe hardware so can not test it by myself. I'd appreciate if someone could test this fix !

Sep 26 2024, 8:42 AM
zlei updated subscribers of D46794: axgbe: Fix setting promisc mode.
Sep 26 2024, 8:40 AM
zlei requested review of D46794: axgbe: Fix setting promisc mode.
Sep 26 2024, 8:40 AM
zlei committed rG5d07b8f51499: iflib: Fix compiler warnings (authored by stevek).
iflib: Fix compiler warnings
Sep 26 2024, 5:21 AM
zlei committed rG2f3af838e6fc: iflib: Correct indentation according to style(9) (authored by stevek).
iflib: Correct indentation according to style(9)
Sep 26 2024, 5:21 AM
zlei committed rG647860bff214: iflib: Many style fixes (authored by zlei).
iflib: Many style fixes
Sep 26 2024, 5:21 AM
zlei committed rGa8eb9e3844da: iflib: Prefer C99's __func__ over GCC's __FUNCTION__ (authored by zlei).
iflib: Prefer C99's __func__ over GCC's __FUNCTION__
Sep 26 2024, 5:21 AM

Sep 25 2024

zlei added a comment to D46187: Use iflib_if_get_counter_default() to get output dropped packets.

Seems good.

I think, with these stats being combined, it would be very important to think about if they are individually exposed (in the sysctl tree?) whilst one may need to dive in and figure out where the drops are actually happening but that is just a general comment.

Sep 25 2024, 10:10 AM

Sep 24 2024

zlei added a comment to D46759: release: add optional OCI images.

Glad to have this OCI (Open Container Initiative) image :)

Sep 24 2024, 3:52 PM
zlei requested review of D46770: if_enc(4): Make enc_add_hhooks() never fail.
Sep 24 2024, 2:37 PM
zlei added inline comments to D46749: sound: Move global variable initialization to sound_modevent().
Sep 24 2024, 10:05 AM
zlei accepted D46372: ena: Fix leaking ifmedia resources on detach.
Sep 24 2024, 5:10 AM
zlei committed rG7b657faa655c: bpf: Some style and white space cleanup (authored by zlei).
bpf: Some style and white space cleanup
Sep 24 2024, 5:03 AM
zlei committed rG7ba975426834: bpf: Add a comment on the large `#ifdef _KERNEL` block (authored by zlei).
bpf: Add a comment on the large `#ifdef _KERNEL` block
Sep 24 2024, 5:03 AM
zlei committed rG6c2430c72b4c: bpf: Add IfAPI analogue for bpf_peers_present() (authored by jhibbits).
bpf: Add IfAPI analogue for bpf_peers_present()
Sep 24 2024, 4:32 AM
zlei committed rGf97d0c91eefc: bpf: Some style and white space cleanup (authored by zlei).
bpf: Some style and white space cleanup
Sep 24 2024, 4:32 AM
zlei committed rGe8ced9914389: bpf: Add a comment on the large `#ifdef _KERNEL` block (authored by zlei).
bpf: Add a comment on the large `#ifdef _KERNEL` block
Sep 24 2024, 4:32 AM
zlei committed rG4bf231d10070: bpf: Update a comment (authored by zlei).
bpf: Update a comment
Sep 24 2024, 4:32 AM
zlei committed rG87841ead405f: kernel: Fix defining of .init_array and .fini_array sections (authored by zlei).
kernel: Fix defining of .init_array and .fini_array sections
Sep 24 2024, 4:16 AM

Sep 22 2024

zlei updated subscribers of D46187: Use iflib_if_get_counter_default() to get output dropped packets.
Sep 22 2024, 5:18 PM
zlei added a reviewer for D46186: iflib: Add iflib managed counters support: jhb.
Sep 22 2024, 5:18 PM
zlei updated subscribers of D46186: iflib: Add iflib managed counters support.
Sep 22 2024, 5:17 PM
zlei requested review of D46751: iflib: Make txq mp ring stats persistent.
Sep 22 2024, 5:13 PM
zlei committed rGbb5f70161454: kernel: Add defination of .init_array and .fini_array for all other platforms (authored by zlei).
kernel: Add defination of .init_array and .fini_array for all other platforms
Sep 22 2024, 2:49 PM
zlei committed rG1d94490aee5c: kernel: Fix defining of .init_array and .fini_array sections (authored by zlei).
kernel: Fix defining of .init_array and .fini_array sections
Sep 22 2024, 2:49 PM
zlei committed rGb90ba458dcae: iflib: Prefer C99's __func__ over GCC's __FUNCTION__ (authored by zlei).
iflib: Prefer C99's __func__ over GCC's __FUNCTION__
Sep 22 2024, 2:11 AM
zlei committed rGfa7045f99cdb: iflib: Many style fixes (authored by zlei).
iflib: Many style fixes
Sep 22 2024, 2:11 AM
zlei committed rG0ca553d761e5: iflib: Ignore fa7045f99cdb in blame (authored by zlei).
iflib: Ignore fa7045f99cdb in blame
Sep 22 2024, 2:11 AM
zlei committed rG55ea43ce4b1b: git-blame-ignore-revs: Ignore f3754afd5901 in blame (authored by zlei).
git-blame-ignore-revs: Ignore f3754afd5901 in blame
Sep 22 2024, 1:29 AM

Sep 21 2024

zlei committed rG9c3fc1da7b3c: mips: Make the variable machine const (authored by zlei).
mips: Make the variable machine const
Sep 21 2024, 4:19 AM
zlei committed rGe38f24446f09: kernel: Make some compile time constant variables const (authored by zlei).
kernel: Make some compile time constant variables const
Sep 21 2024, 4:19 AM
zlei committed rG57f268ccfc66: zfs: cherry-pick change from openzfs (authored by zlei).
zfs: cherry-pick change from openzfs
Sep 21 2024, 4:19 AM

Sep 20 2024

zlei added a comment to D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode.

I'd like to do a direct commit to stable/13 branch for the mips part.

Oh, please go ahead. I forgot about mips.

Sep 20 2024, 3:31 PM
zlei committed rG313bd4df8b13: mips: Allow sysctl hw.machine in capability mode (authored by val_packett.cool).
mips: Allow sysctl hw.machine in capability mode
Sep 20 2024, 3:28 PM
zlei added a comment to D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode.

@emaste I'd like to do a direct commit to stable/13 branch for the mips part. The very first revision actually has change for mips arch, and @manu accepted that.
Any objections ?

Sep 20 2024, 2:29 PM
zlei added a comment to D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode.

This can also apply to stable/13 branch. Do you have plan MFC the commit ?

I can, sure.

Sep 20 2024, 1:37 PM
zlei committed rG99215a194483: git-blame-ignore-revs: Ignore 1baf6164e4d6 in blame (authored by zlei).
git-blame-ignore-revs: Ignore 1baf6164e4d6 in blame
Sep 20 2024, 10:11 AM
zlei committed rG1baf6164e4d6: bpf: Some style and white space cleanup (authored by zlei).
bpf: Some style and white space cleanup
Sep 20 2024, 10:11 AM
zlei committed rGe30b58846003: bpf: Add a comment on the large `#ifdef _KERNEL` block (authored by zlei).
bpf: Add a comment on the large `#ifdef _KERNEL` block
Sep 20 2024, 10:11 AM
zlei committed rG497f577f460b: kernel: Make some compile time constant variables const (authored by zlei).
kernel: Make some compile time constant variables const
Sep 20 2024, 10:06 AM
zlei committed rG611d52a19698: zfs: cherry-pick change from openzfs (authored by zlei).
zfs: cherry-pick change from openzfs
Sep 20 2024, 10:06 AM
Herald added a reviewer for D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode: andrew.

This can also apply to stable/13 branch. Do you have plan MFC the commit ?

Sep 20 2024, 10:01 AM

Sep 19 2024

zlei added inline comments to D46683: Introduce ip_af_t.
Sep 19 2024, 12:28 AM

Sep 15 2024

zlei added a comment to D46649: pf: merge pf_test() and pf_test6().
In D46649#1063973, @kp wrote:
In D46649#1063965, @kp wrote:

I'm not sure I like defining a new enum for this, and converting between it and sa_family_t. It's likely have to spread pretty far in the pf code, or end up with conversions everywhere.

Or maybe I do like it after all. clang and gcc seem happy to convert between the two if I define PF_AF_INET = AF_INET and PF_AF_INET6 = AF_INET6, which seems like a sensible thing to do.
I'll update this review when my test builds are done.

Sep 15 2024, 12:51 PM

Sep 14 2024

zlei added a comment to D46653: kyua: Do not count skipped as passed in test cmd.

I'm in favour of the change. The current output is quite misleading.

BTW, in the FreeBSD regression test suite, it's basically impossible to avoid skipping some tests:

  • the are tests that get skipped if ipfw.ko is not loaded, and tests which are skipped if ipfw.ko /is/ loaded,

I've ever planed to convert ipfw's tunable net.inet.ip.fw.default_to_accept a per-vnet one. Further plan is introducing per-jail's env parameter [1] so that the host and testing jails do not influence each other. Do you have interests with that ?

Sep 14 2024, 9:23 AM
zlei accepted D46598: pf: remove unused argument 'h' from various function.

Looks good to me.

Sep 14 2024, 8:45 AM
zlei accepted D46597: pf: merge pf_scrub_ip() and pf_scrub_ip6().
Sep 14 2024, 8:33 AM
zlei accepted D46596: pf: do not pass af to PFLOG_PACKET.

Looks good to me.

Sep 14 2024, 8:24 AM
zlei accepted D46595: pf tests: ensure we don't NAT to link-local addresses.

Looks good to me.

Sep 14 2024, 8:16 AM
zlei accepted D46593: pf: remove unneeded double pointer to pf_scrub_ip(6)().

Looks good to me.

Sep 14 2024, 8:09 AM
zlei added a comment to D46594: pf: exclude link local address from the dynamic interface address pool.

+1 for this long time wanted improvement :)

Sep 14 2024, 8:08 AM