Page MenuHomeFreeBSD
Differential D46821

sound: Move root feeder initialization to separate function
ClosedPublic
Actions

Authored by christos on Sep 27 2024, 5:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 7:09 PM
Unknown Object (File)
Fri, Nov 1, 3:51 AM
Unknown Object (File)
Fri, Nov 1, 1:50 AM
Unknown Object (File)
Mon, Oct 28, 8:51 PM
Unknown Object (File)
Thu, Oct 24, 7:10 PM
Unknown Object (File)
Oct 19 2024, 9:15 PM
Unknown Object (File)
Oct 18 2024, 11:08 AM
Unknown Object (File)
Oct 5 2024, 12:03 AM
View All 19 Files
Subscribers
imp
zlei

Details

Reviewers
markj
emaste
dev_submerge.ch
zlei
Commits
rG1f4d968a299e: sound: Move root feeder initialization to separate function
rG97570db05ced: sound: Move root feeder initialization to separate function
Summary

While here, fix some style errors.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Sep 27 2024, 5:55 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 27 2024, 5:55 PM
christos requested review of this revision.Sep 27 2024, 5:55 PM
Harbormaster completed remote builds in B59632: Diff 143821.Sep 27 2024, 5:55 PM
christos mentioned this in D46749: sound: Move global variable initialization to sound_modevent().Sep 27 2024, 5:55 PM
zlei accepted this revision.Sep 29 2024, 3:15 AM
zlei added a subscriber: zlei.
zlei added inline comments.
sys/dev/sound/pcm/feeder.c
65

The SYSINIT is the slow path. I've not tested yet but I bet M_WAITOK will be OK. So that we can guarantee that the root feeder is always available.

This revision is now accepted and ready to land.Sep 29 2024, 3:15 AM
christos added inline comments.Sep 29 2024, 10:52 AM
sys/dev/sound/pcm/feeder.c
65

I think we could change to M_WAITOK in feeder_register() as well.

christos marked an inline comment as done.Sep 29 2024, 1:34 PM
christos added inline comments.
sys/dev/sound/pcm/feeder.c
65

@zlei D46845

dev_submerge.ch accepted this revision.Sep 29 2024, 2:40 PM
zlei added inline comments.Sep 29 2024, 3:16 PM
sys/dev/sound/pcm/feeder.c
63

A nit here, you can assert, aka MPASS(feedercnt == 0), to ensure in future the change of order of SYSINIT will not break. The current change is absolutely OK, but just in case.

christos marked an inline comment as done.Sep 29 2024, 3:33 PM
christos added inline comments.
sys/dev/sound/pcm/feeder.c
63

Good idea. Will commit the patch with the MPASS as well, but will the review here as-is here since it's accepted.

markj accepted this revision.Sep 30 2024, 8:16 AM

When making a non-functional change like this, it's nice to state why in the commit message.

Closed by commit rG97570db05ced: sound: Move root feeder initialization to separate function (authored by christos). · Explain WhyOct 18 2024, 8:45 AM
This revision was automatically updated to reflect the committed changes.
christos marked an inline comment as done.
christos added a commit: rG97570db05ced: sound: Move root feeder initialization to separate function.
christos added a commit: rG1f4d968a299e: sound: Move root feeder initialization to separate function.Oct 20 2024, 11:22 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
69 lines

Diff 145086

View Options

sys/dev/sound/pcm/feeder.c

Loading...