- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 13 2020
OK, thank you for this change. Approved!
Dec 12 2020
Dec 11 2020
Go ahead then, thanks!
Dec 10 2020
In D27524#615446, @mgorny_gentoo.org wrote:In D27524#615445, @bcr wrote:In D27524#615441, @mgorny_gentoo.org wrote:Updated as requested. Note that this shouldn't be probably pushed yet, as it could confuse users before LLVM 12.0.0 is released.
But it does say "... starting with LLDB 12.0.0", so the confusion would be minimal, right?
I'm not sure about that. When I read stuff like this I usually think 'I am using the newest version, so that must be it'. However, IIRC there's no release schedule for 12 yet.
In D27524#615441, @mgorny_gentoo.org wrote:Updated as requested. Note that this shouldn't be probably pushed yet, as it could confuse users before LLVM 12.0.0 is released.
Dec 9 2020
OK for the man page side of things.
Minor fix, then it is good to go.
Thanks for the patch.
OK from manpages.
Dec 8 2020
Dec 6 2020
All good to go from manpages.
Dec 5 2020
Dec 4 2020
A bit of indentation needed, the text is good.
A bit more indentation is needed in this file, the text itself is fine.
A single thing needs fixing, then we're done with this part.
Looks good now, I can fix some of the indentation when the whole chapter gets committed.
This file is complete as it is now. Thank you!
Ok from manpages.
Dec 3 2020
Can you describe your use case for this and why it should become part of the general installer?
Then go for it!
A new extra comments.
Overall, I like the FAQ and the questions discussed therein.
Dec 2 2020
The writing is great. I've added a few comments on some things to fix.
I look forward to the final piece.
Found a missing word.
I look forward to have this feature, thanks for implementing it.
Dec 1 2020
Looking good to me. Thanks for doing the work!
Nov 28 2020
Approved, thanks for digging up the history.
Nov 25 2020
Nov 22 2020
Sieht gut aus, danke!
Nov 19 2020
Excellent, that looks good now. Thank you!
Nov 18 2020
OK, thanks for the manpage fixes. That part looks good now.
In D27264#608939, @fernape wrote:In D27264#608857, @bcr wrote:The examples look good. Maybe another one to show how to do a case-sensitive search (i.e. just uppercase)?
Except for the example with -i the rest of them are case sensitive. The example reading from the standard input uses the uppercase BSD in case sensitive mode. Do you mean a separate example?
Thanks!
A few minor things in the man page. You can check it with "mandoc -Tlint" and textproc/igor.
The examples look good. Maybe another one to show how to do a case-sensitive search (i.e. just uppercase)?
Nov 17 2020
Looks good to me. Don't forget the .Dd bump.
Nov 16 2020
I like your writeup of this chapter. A few comments inline for style fixes, nothing major.
OK, this looks better. Just a few more things to flesh out before it's ready.
Minor nit. We can also run over the document with a search & replace later and look for "FreeBSD" and replace it with "&os;".
Nov 15 2020
Looks good to me, can't say much about the ipfw specifics, though.
Nov 14 2020
Small typo found
Nov 9 2020
I like the writing (content, size, well written). We just need to fix a few style things, then it is ready.
Nothing major really, I've included a couple of links to the FDP primer.
Nov 7 2020
Nov 5 2020
Oct 29 2020
I only know that I know nothing...
I agree. Maybe you can shorten the examples to a few lines and indicate the rest with ... without loosing too much context?
Excellent, consistency is king. ;-)
Ha, my calendar says the same. What a coincidence. Let's fix it.
Hehe, that's fine. Good to go then! Thank you.
Oct 27 2020
Ok from manpages. Good to modernize this a bit.
Oct 26 2020
OK from manpages as well.
Oct 25 2020
I'm good with that change.
Sure, I'm fine with a follow-up commit to fix those.
Minor writing style nit.
Oct 23 2020
Cool, so approved then.
Just a question about whitespace, the rest looks good.
Can you provide the image file as well?
It's a good starting text. A sweep through it for the use of "you" would be good.
Oct 22 2020
Good to go.
Good to go, thanks for your work on the report!
Oct 20 2020
I think it is OK, since vim is popular enough, even though it is not in the base system. If we can't find an example that uses a base system utility, that is.
Oct 19 2020
Reads well, thanks for this addition!
Oct 18 2020
I think we won't progress here if we don't get someone else to review the src parts.
@cperciva: Can you take a look at it?
Oct 16 2020
Oct 15 2020
Nur ein paar Kleinigkeiten, der Rest ist in Ordnung. Danke!
Oct 13 2020
OK from manpages.
Oct 12 2020
OK from manpages.
Oct 11 2020
Looks good. Thanks for taking care of it.
Man page is fine now, thanks!
OK from manpages.
Minor line break needed in the man page.
Thanks for implementing that feature.
There is a minor mandoc issue, easy to fix. Running "mandoc -Tlint" and textproc/igor will usually tell you about them.