Page MenuHomeFreeBSD
Differential D27519

add deprecation notice for bvmdebug and bvmconsole
ClosedPublic
Actions

Authored by rew on Dec 9 2020, 12:02 AM.
Tags
None
Referenced Files
F168954223: D27519.id80536.diff
Sun, Aug 30, 10:48 PM
F168902645: D27519.diff
Sun, Aug 30, 4:38 PM
Unknown Object (File)
Sat, Aug 29, 8:18 AM
Unknown Object (File)
Fri, Aug 28, 3:03 PM
Unknown Object (File)
Wed, Aug 26, 4:09 PM
Unknown Object (File)
Wed, Aug 26, 2:14 PM
Unknown Object (File)
Wed, Aug 26, 10:52 AM
Unknown Object (File)
Tue, Aug 25, 1:16 AM
View All Files
Subscribers
bcr
bcran
imp
rgrimes

Details

Reviewers
kevans
jhb
grehan
Group Reviewers
manpages
bhyve
Commits
rS368519: Add deprecation notice for bvmconsole and bvmdebug
Summary

Emit runtime warnings for bvmconsole, bvmdebug, and bhyve.

bvmconsole and bvmdebug don't have device_attach routines, so I dropped
gone_in where (I think) it would get the most visiblity.

This review will be followed up by https://reviews.freebsd.org/D27490

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rew created this revision.Dec 9 2020, 12:02 AM
Herald added a reviewer: manpages. · View Herald TranscriptDec 9 2020, 12:02 AM
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
rew requested review of this revision.Dec 9 2020, 12:02 AM
Harbormaster completed remote builds in B35268: Diff 80466.Dec 9 2020, 12:02 AM
grehan accepted this revision.Dec 9 2020, 12:05 AM
This revision is now accepted and ready to land.Dec 9 2020, 12:05 AM
bcr accepted this revision as: manpages.Dec 9 2020, 9:03 AM
bcr added a subscriber: bcr.

OK from manpages.

jhb accepted this revision.Dec 9 2020, 4:54 PM

Minor suggestions, thanks!

usr.sbin/bhyve/bhyve.8
107 ↗(On Diff #80466)

Perhaps s/gone/removed/

149 ↗(On Diff #80466)

Same

usr.sbin/bhyve/bhyverun.c
1127 ↗(On Diff #80466)

Here as well.

Closed by commit rS368519: Add deprecation notice for bvmconsole and bvmdebug (authored by rew). · Explain WhyDec 10 2020, 6:07 PM
This revision was automatically updated to reflect the committed changes.
rew added a commit: rS368519: Add deprecation notice for bvmconsole and bvmdebug.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
bvm/
2 lines
2 lines
usr.sbin/
bhyve/
8 lines
2 lines

Diff 80536

View Options

head/sys/dev/bvm/bvm_console.c

Loading...
View Options

head/sys/dev/bvm/bvm_dbg.c

Loading...
View Options

head/usr.sbin/bhyve/bhyve.8

Loading...
View Options

head/usr.sbin/bhyve/bhyverun.c

Loading...