Page MenuHomeFreeBSD

deprecate/remove bvmconsole and bvmdebug
ClosedPublic

Authored by rew on Dec 5 2020, 10:47 PM.

Details

Reviewers
allanjude
kevans
jhb
grehan
Group Reviewers
manpages
bhyve
Summary

Now that bhyve(8) supports UART, bvmconsole and bvmdebug are no longer needed.

In addition to removing the kernel bits of bvmdebug and bvmconsole, this removes
the -b and -g flag from bhyve(8). These two flags were marked as 'will be
deprecated in a future version' when they were introduced.

Mentioned in PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233230

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 35211
Build 32156: arc lint + arc unit

Event Timeline

rew requested review of this revision.Dec 5 2020, 10:47 PM
This revision is now accepted and ready to land.Dec 6 2020, 12:57 AM
bcr added a subscriber: bcr.

All good to go from manpages.

Given that Peter approved and the mailing list post is seemingly quiet thus far, give it another ~3 days to dredge up any objections then commit the solid "Removed in 13" verbiage with a pointer (in text, not in commit tags of course) to this review. I'd probably give it another day or two after that for any complaints from folks that might see it in commit log/mail first to object, then commit this.

In any event, both are:

Approved by: kevans (mentor)

usr.sbin/bhyve/bhyve.8
107

Let's do this in two steps: change the wording for both in advance of this commit to:

This option is deprecated and will be removed in
.Fx 13.0 .

and MFC that. That way folks get more concrete notice that it will be removed in their next major upgrade.

usr.sbin/bhyve/bhyve.8
107

s/removed/gone/

Technically we'd want the drivers in 12 and bhyve in 12 to probably emit runtime warnings as well perhaps, but these things are so obscure I'm less worried about that. The driver changes for the kernel at least in 12 are fairly easy, just add a 'gone_in' line to the device_attach routines.