Page MenuHomeFreeBSD

Add HISTORY sections for pthread(3) functions
Needs RevisionPublic

Authored by gbe on Sat, Nov 14, 12:49 PM.

Details

Reviewers
jilles
Group Reviewers
manpages
Summary

Add HISTORY sections for pthread(3) functions

Test Plan

mandoc output review and 'mandoc -Tlint checks'

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 34796
Build 31845: arc lint + arc unit

Event Timeline

gbe requested review of this revision.Sat, Nov 14, 12:49 PM
gbe created this revision.

That's a nice update to our history section, thanks!

Do you perhaps know of an easy way to verify the FreeBSD version numbers to ease the reviewing process?

Small typo found

share/man/man3/pthread_cond_wait.3
104

s/fucntion/function/

  • pthread_cond_wait(3): Fix a typo
gbe marked an inline comment as done.Sat, Nov 14, 1:37 PM

@bcr thanks for spotting this, the typo is fixed.

@0mp you can verified the release dates by looking at the FreeBSD Wikipedia entry, in the german Wikipedia, and correlate this with the respective functions. The functions can be easily looked up with find and grep.

jilles requested changes to this revision.Sat, Nov 14, 7:33 PM
jilles added a subscriber: jilles.

A pthread implementation "libc_r" was already added in 2.2-release, which contained most of these functions.

This revision now requires changes to proceed.Sat, Nov 14, 7:33 PM

A pthread implementation "libc_r" was already added in 2.2-release, which contained most of these functions.

The HISTORY sections I added is based on the implementation of libthr. I could extend the HISTORY sections and mention "xyz first appeared in FreeBSD 5.1 as a new implementation within libthr(3)".

Also possible would be "xyz first appeared in FreeBSD 2.2 within libc_r(3) and was replaced by the libthr(3) implementation in FreeBSD 5.1".

Any preference?

In D27216#607710, @gbe wrote:

A pthread implementation "libc_r" was already added in 2.2-release, which contained most of these functions.

The HISTORY sections I added is based on the implementation of libthr. I could extend the HISTORY sections and mention "xyz first appeared in FreeBSD 5.1 as a new implementation within libthr(3)".

Also possible would be "xyz first appeared in FreeBSD 2.2 within libc_r(3) and was replaced by the libthr(3) implementation in FreeBSD 5.1".

Any preference?

Probably the latter, but for completeness, libkse should also be mentioned (introduced in FreeBSD 5.0, I think). I remember replacing libkse with libthr via libmap.conf in the FreeBSD 6 days for a nice performance boost.

There was also a LinuxThreads port but that was not in base, so it need not be mentioned here.