Page MenuHomeFreeBSD

WINE Section: WINE Configuration
Needs ReviewPublic

Authored by acpkendo_gmail.com on Nov 9 2020, 3:37 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Adding the section describing prefixes and the configuration of WINE with the winecfg utility.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

acpkendo_gmail.com created this revision.

I like the writing (content, size, well written). We just need to fix a few style things, then it is ready.
Nothing major really, I've included a couple of links to the FDP primer.

chapter.xml
12

Is there a "that" missing between "applications" and "run"?

21

You can replace the &gt; with > and the &lt; with < here.

32

update -> updates

or

and "will" automatically update

36

You can mark them up as directories as described in section 9.6.6 here:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/docbook-markup-inline-elements.html

37

The &amp; can also be safely replaced with &.

63

These <emphasis> tags would better be replaced with <filename>.

71

You can mark "drive_c" up with <filename> as well.

76

s/varous/various/

125

You can use <varname> here instead of <emphasis>.

269

Yes, this is a correctly indented <para>. The lines below align under the first "a" of <para>.

316

Sentences need to start right after <para>. The closing </para> also needs to be right after the last word of the sentence. If that should be too long, then break the whole word (with </para> right behind it) into the next line.

356

Another <filename> markup here for dosdevices/.

Also, you don't need to provide <directory> here, since it is clear from the markup (and the / at the end). See the /etc/rc.local example here:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-guidelines.html

362

Use <filename> tags around /mnt/cdrom

380

There is a superfluous space after "Browse" and the closing tag.

Updates per feedback, a couple of outstanding questions.

chapter.xml
12

I can add it, although the connotation is actually "applications that have been run through WINE," a structure which I usually shorten to just the verb.

269

@bcr, can you clarify the fix to be made here? I did move the closing </para> up to the previous line (which was also missing a colon), is there something else?

Updates per feedback, will update again pending answers to a couple of outstanding questions.

OK, this looks better. Just a few more things to flesh out before it's ready.

chapter.xml
12

OK, that makes sense to me. Then leave it as it is.

21

They're still in the updated patch.

269

@bcr, can you clarify the fix to be made here? I did move the closing </para> up to the previous line (which was also missing a colon), is there something else?

See here on how the <para> tags should be used and aligned:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/docbook-markup-block-elements.html

It seems that the </para> still needs to be moved up right after &os; to look like this: &os;</para>

If you have FreeBSD, you can install textproc/igor and run "igor chapter.xml" over it. It will tell you some of the common style errors and suggests fixes.

See updated diff for detail.

Final clean-up, including filename/varname tags, indentation, and conversion issues on entities.

Kindly ignore diff 80302, it's incomplete. This version has all the required changes.

A single thing needs fixing, then we're done with this part.

chapter.xml
27

You can remove the redundant phrase "the" and "file" (the latter ended up within the <filename> tag).