Adding the section describing prefixes and the configuration of WINE with the winecfg utility.
Details
- Reviewers
- None
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
I like the writing (content, size, well written). We just need to fix a few style things, then it is ready.
Nothing major really, I've included a couple of links to the FDP primer.
chapter.xml | ||
---|---|---|
13 | Is there a "that" missing between "applications" and "run"? | |
22 | You can replace the > with > and the < with < here. | |
33 | update -> updates or and "will" automatically update | |
37 | You can mark them up as directories as described in section 9.6.6 here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/docbook-markup-inline-elements.html | |
38 | The & can also be safely replaced with &. | |
64 | These <emphasis> tags would better be replaced with <filename>. | |
72 | You can mark "drive_c" up with <filename> as well. | |
77 | s/varous/various/ | |
126 | You can use <varname> here instead of <emphasis>. | |
270 | Yes, this is a correctly indented <para>. The lines below align under the first "a" of <para>. | |
317 | Sentences need to start right after <para>. The closing </para> also needs to be right after the last word of the sentence. If that should be too long, then break the whole word (with </para> right behind it) into the next line. | |
357 | Another <filename> markup here for dosdevices/. Also, you don't need to provide <directory> here, since it is clear from the markup (and the / at the end). See the /etc/rc.local example here: | |
363 | Use <filename> tags around /mnt/cdrom | |
381 | There is a superfluous space after "Browse" and the closing tag. |
Updates per feedback, a couple of outstanding questions.
chapter.xml | ||
---|---|---|
13 | I can add it, although the connotation is actually "applications that have been run through WINE," a structure which I usually shorten to just the verb. | |
270 | @bcr, can you clarify the fix to be made here? I did move the closing </para> up to the previous line (which was also missing a colon), is there something else? |
Updates per feedback, will update again pending answers to a couple of outstanding questions.
OK, this looks better. Just a few more things to flesh out before it's ready.
chapter.xml | ||
---|---|---|
13 | OK, that makes sense to me. Then leave it as it is. | |
22 | They're still in the updated patch. | |
270 |
See here on how the <para> tags should be used and aligned: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/docbook-markup-block-elements.html It seems that the </para> still needs to be moved up right after &os; to look like this: &os;</para> If you have FreeBSD, you can install textproc/igor and run "igor chapter.xml" over it. It will tell you some of the common style errors and suggests fixes. |
Final clean-up, including filename/varname tags, indentation, and conversion issues on entities.
Kindly ignore diff 80302, it's incomplete. This version has all the required changes.
A single thing needs fixing, then we're done with this part.
chapter.xml | ||
---|---|---|
28 | You can remove the redundant phrase "the" and "file" (the latter ended up within the <filename> tag). |