Page MenuHomeFreeBSD

su.1: Try to clarify confusing -c options
Changes PlannedPublic

Authored by 0mp on Oct 25 2020, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 5:18 AM
Unknown Object (File)
Nov 22 2023, 1:13 PM
Unknown Object (File)
Nov 10 2023, 5:19 AM
Unknown Object (File)
Oct 9 2023, 4:08 AM
Unknown Object (File)
Jul 20 2023, 3:21 AM
Unknown Object (File)
May 24 2023, 3:39 AM
Unknown Object (File)
May 3 2023, 6:26 PM
Unknown Object (File)
Apr 26 2023, 4:00 AM
Subscribers

Details

Reviewers
emaste
Group Reviewers
manpages
Summary
su.1: Try to clarify flags handling

The -c flag to su(1) seems to be particularly confusing, especially to users
who are not used to the convention of providing flags before arguments to
utilities. Try to document various ways su(1) may interpret flags,
especially -c.

PR:	250405

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250405

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34375
Build 31485: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Oct 25 2020, 12:32 PM

Minor writing style nit.

usr.bin/su/su.1
221

s/your/the/

(discouraging the use of "you")

usr.bin/su/su.1
221

Oh yeah, right. I think I'd like to tackle this one in another revision as the whole manual is using you/your all the time currently :(

What do you think?

Sure, I'm fine with a follow-up commit to fix those.

Hmmm, I'm a bit puzzled, as after reading the existing version of the manual, it is possible to figure out the difference between the -c flags... I am not if adding extra examples outside the EXAMPLES section helps...

In D26941#601252, @0mp wrote:

Hmmm, I'm a bit puzzled, as after reading the existing version of the manual, it is possible to figure out the difference between the -c flags... I am not if adding extra examples outside the EXAMPLES section helps...

Since phabricator add me to the mix, I am going to participate :-)

I would add those two examples to the EXAMPLES section one right after the other. I think examples in the middle of a description are easier to miss.

I would also write all the description for the examples before the commands and not after. Specially since there are sentences like "same as above" and right above we have the command for the current example, not the previous one (which is two paragraphs above).

In D26941#601252, @0mp wrote:

Hmmm, I'm a bit puzzled, as after reading the existing version of the manual, it is possible to figure out the difference between the -c flags... I am not if adding extra examples outside the EXAMPLES section helps...

Since phabricator add me to the mix, I am going to participate :-)

Thank you!

I would add those two examples to the EXAMPLES section one right after the other. I think examples in the middle of a description are easier to miss.

Good point, perhaps I should do that.

I would also write all the description for the examples before the commands and not after. Specially since there are sentences like "same as above" and right above we have the command for the current example, not the previous one (which is two paragraphs above).

Hmm, at this point I guess it is inevitable to just rewrite the EXAMPLES section completely with good examples.

0mp planned changes to this revision.Oct 27 2020, 9:42 AM