- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 21 2015
Nov 19 2015
Nov 18 2015
Nov 7 2015
Nov 6 2015
Nov 3 2015
In D3654#85162, @kib wrote:Yes, the restart problem is there. So, do you agree with having something along this lines (with or without the handling of timeout spent time) ?
Nov 1 2015
Oct 31 2015
Downside of this is that timeouts of the affected calls (kqueue/select/poll/nanosleep) are reset after a debug interrupt. If debug interrupts occur more often than the timeout, the calls will never time out. This is probably less harmful than the current [EINTR] but still a bug.
Oct 27 2015
Oct 25 2015
Oct 22 2015
Oct 18 2015
Reading the code, this looks OK, but in compilation an undesirable side effect can be seen. This is on amd64 with 11-current's default clang. The improvements to res_init() cause it to fall below a threshold and be inlined everywhere, leading to a 15% code size increase rather than the expected decrease (in the "text" column of size(1)).
Oct 11 2015
Sep 30 2015
Committed to head as SVN r288430 with the change to the man page. Thanks Warren Block for the review.
Sep 27 2015
Sep 19 2015
Sep 16 2015
Sep 13 2015
Sep 12 2015
Fix bug in arglist handling.
Sep 10 2015
Sep 9 2015
Sep 2 2015
Aug 30 2015
Looks OK apart from minor style issues.
Aug 29 2015
Aug 28 2015
Aug 25 2015
Aug 23 2015
Aug 22 2015
Aug 20 2015
Aug 19 2015
Aug 18 2015
Aug 16 2015
In D3043#68914, @kib wrote:The diff is enormous and it pollutes a lot of unrelated places. E.g. the loader Makefiles changes or the forced undef fortify in libc/strings/stdio, as I understand, to avoid recursion.
Can the pollution be minimized somehow ? Can the patch be split into digestable pieces ?
Aug 15 2015
Aug 14 2015
Aug 11 2015
Aug 9 2015
Aug 8 2015
Aug 5 2015
Aug 2 2015
In D2172#65244, @theraven wrote:kmacy has been working on bringing over the notify(3) APIs from Darwin[1], which appear to provide a superset of this functionality. It would be worth comparing the two and seeing what can be shared between the two. Ideally, the file descriptor returned by notify_register_file_descriptor would be of the same kind as that returned by eventfd and, outside of the Linuxulator (where it needs to be a system call for binary compat), we might be able to implement the eventfd stuff entirely in libc using the same system calls as notify(3).
[1] https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man3/notify.3.html
Aug 1 2015
Jul 11 2015
Jul 5 2015
Jun 28 2015
Jun 24 2015
Jun 20 2015
Committed to head.
Looks good to me.
Jun 19 2015
Jun 6 2015
May 31 2015
May 14 2015
May 10 2015
May 5 2015
The concept of allowing to set creation time looks good to me.
May 3 2015
Is _fixtelldir() actually needed? I noticed a bug in it, and if loc_loc == 0, there doesn't seem harm in lseek() + getdirentries().
Apr 27 2015
Apr 26 2015
Apr 25 2015
Apr 24 2015
Looks good to me.
Apr 23 2015
I have some small remarks that apply to all three but I only wrote them in chflags.
Apr 18 2015
By the way, a workaround for the script is:
trap ' exit' INT
Looks good to me.
If you're changing this, please make the interaction between -h and -R more sensible, as specified by symlink(7) and POSIX (though in the latter case not for chmod and chflags)
In that interpretation, it is never necessary to specify -h with -R; instead, -P implies -h, and -H implies -h for those files listed on the command line (not found in the tree walk).Thanks for looking at this, I'm a little confused by your statement about "-H implies -h" as it seems to contradict symlink(7) specifically:
"The -H flag causes symbolic links specified on the command line to be dereferenced both for the purposes of the action to be performed and the tree walk, and it is as if the user had specified the name of the file to which the symbolic link pointed."How I interpret that is that -H disables -h behaviour for the files specified on the command line only as they should already be dereferenced.
Apr 17 2015
If you're changing this, please make the interaction between -h and -R more sensible, as specified by symlink(7) and POSIX (though in the latter case not for chmod and chflags). In that interpretation, it is never necessary to specify -h with -R; instead, -P implies -h, and -H implies -h for those files listed on the command line (not found in the tree walk). This may not be a fully compatible change, but it fixes confusing behaviour that commands like "chown -R u:g tree" leave symlinks alone.
The man page and the usage message still contain optional arguments for -i and -I.
Apr 4 2015
Apr 3 2015
I've reviewed the patch as if it's accepted to add this to the native API. I think it is possible to split the patch and first add the new fd type and kern_eventfd.c for the Linuxulator's use without committing to a new native API. This is definitely a required feature for the Linuxulator soon, if not now.
Mar 29 2015
This is not really a lot of code, but I'm not sure it should be added as a fixed part of the native API, since it does not do much that is not already possible using pipe() or kqueue().
Mar 24 2015
This may work better as a "command", i.e. IP_* thing. For one, unmounting parts of the jail and then running a stop command inside the jail is not a good idea. The code already has a concept of dependencies between commands and that should be taken advantage of.
Mar 14 2015
Mar 11 2015
Mar 6 2015
Feb 5 2015
Looks good to me.
Feb 4 2015
Can you find out which file is returning [EAGAIN] while writing, and who is setting it non-blocking temporarily? It is also possible that a kernel bug causes [EAGAIN] on a write even though non-blocking mode is off.
Feb 1 2015
I think getting rid of the cast is a win regardless of -Wcast-qual.