HomeFreeBSD

MFC r282482: cp: Remove fts sorting.

Description

MFC r282482: cp: Remove fts sorting.

In an attempt to improve performance, cp reordered directories first
(although the comment says directories last). This is not effective with new
UFS layout policies.

The sorting reorders multiple arguments passed to cp, which may be
undesirable.

Additionally, the comparison function does not induce a total order. Per
POSIX, this causes undefined behaviour in qsort().

NetBSD removed the sorting in 2009.

On filesystems that return directory entries in hash/btree order, sorting by
d_fileno before statting improves performance on large directories. However,
this can only be implemented in fts(3).

PR: 53475
Reviewed by: bde (in 2004)

Details

Provenance
jillesAuthored on
Parents
rS282916: Add ELF machine EM_IAMCU, 32-bit Intel MCU
Branches
Unknown
Tags
Unknown