Page MenuHomeFreeBSD
Differential D32029

Convert consumers to use the CPU_FOREACH_SET() macro
ClosedPublic
Actions

Authored by markj on Sep 20 2021, 7:11 PM.
Tags
None
Referenced Files
F161500705: D32029.id95457.diff
Sat, Jul 4, 8:23 AM
Unknown Object (File)
Fri, Jul 3, 12:09 PM
Unknown Object (File)
Fri, Jul 3, 12:18 AM
Unknown Object (File)
Thu, Jul 2, 6:27 PM
Unknown Object (File)
Thu, Jul 2, 7:28 AM
Unknown Object (File)
Tue, Jun 30, 9:18 PM
Unknown Object (File)
Tue, Jun 30, 3:09 PM
Unknown Object (File)
Fri, Jun 26, 4:57 PM
View All Files
Subscribers
bcran
imp
rgrimes
rpokala

Details

Reviewers
rlibby
scottph
kib
cem
jhb
Group Reviewers
bhyve
Commits
rGde8554295b47: cpuset(9): Add CPU_FOREACH_IS(SET|CLR) and modify consumers to use it
rG9068f6ea697b: cpuset(9): Add CPU_FOREACH_IS(SET|CLR) and modify consumers to use it
Summary

This implementation is faster and doesn't modify the cpuset, so it lets
us avoid some unnecessary copying. No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41609
Build 38498: arc lint + arc unit

Event Timeline

markj created this revision.Sep 20 2021, 7:11 PM
Herald added a reviewer: bhyve. · View Herald TranscriptSep 20 2021, 7:11 PM
Herald added subscribers: bcran, rgrimes, rpokala, imp. · View Herald Transcript
markj requested review of this revision.Sep 20 2021, 7:11 PM
Harbormaster completed remote builds in B41609: Diff 95395.Sep 20 2021, 7:11 PM
markj added a parent revision: D32028: bitset(9): Introduce BIT_FOREACH_SET and BIT_FOREACH_CLR.Sep 20 2021, 7:11 PM
cem accepted this revision.Sep 20 2021, 7:16 PM
This revision is now accepted and ready to land.Sep 20 2021, 7:16 PM
jhb accepted this revision.Sep 20 2021, 8:18 PM
kib accepted this revision.Sep 20 2021, 8:26 PM

BTW there is enough similar iterations FFS/CLR done over the signal sets/masks. Do you plan to look at this as well?

markj added a comment.Sep 20 2021, 8:38 PM
In D32029#722803, @kib wrote:

BTW there is enough similar iterations FFS/CLR done over the signal sets/masks. Do you plan to look at this as well?

I will try implementing this for sigsets too. I guess it would be somewhat messy to change the kernel to use bitset(9) for signal sets?

Closed by commit rG9068f6ea697b: cpuset(9): Add CPU_FOREACH_IS(SET|CLR) and modify consumers to use it (authored by markj). · Explain WhySep 21 2021, 4:09 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG9068f6ea697b: cpuset(9): Add CPU_FOREACH_IS(SET|CLR) and modify consumers to use it.
rlibby added inline comments.Sep 21 2021, 5:36 PM
sys/amd64/vmm/io/vlapic.c
895–897

This is currently broken due to the issue with break noted in D32028.

sys/amd64/vmm/vmm_lapic.c
92–94

Again, break is broken.

markj added a reverting change: rGbcdc599dc2a1: Revert "cpuset(9): Add CPU_FOREACH_IS(SET|CLR) and modify consumers to use it".Sep 21 2021, 5:52 PM
markj added inline comments.Sep 21 2021, 5:53 PM
sys/amd64/vmm/io/vlapic.c
895–897

Thanks, I reverted this commit for now.

markj added a commit: rGde8554295b47: cpuset(9): Add CPU_FOREACH_IS(SET|CLR) and modify consumers to use it.Oct 18 2021, 2:09 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
11 lines
vmm/
io/
13 lines
4 lines
i386/
i386/
4 lines
sys/
2 lines
x86/
x86/
4 lines

Diff 95395

View Options

sys/amd64/amd64/mp_machdep.c

Loading...
View Options

sys/amd64/vmm/io/vlapic.c

Loading...
View Options

sys/amd64/vmm/vmm_lapic.c

Loading...
View Options

sys/i386/i386/mp_machdep.c

Loading...
View Options

sys/sys/cpuset.h

Loading...
View Options

sys/x86/x86/mp_x86.c

Loading...