Page MenuHomeFreeBSD
Differential D29921

linuxkpi: make FPU sections thread-safe and NOCTX
ClosedPublic
Actions

Authored by val_packett.cool on Apr 22 2021, 11:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 9:33 AM
Unknown Object (File)
Thu, Apr 11, 7:44 AM
Unknown Object (File)
Mon, Mar 18, 5:43 AM
Unknown Object (File)
Jan 11 2024, 11:16 PM
Unknown Object (File)
Dec 20 2023, 8:33 AM
Unknown Object (File)
Dec 12 2023, 7:50 AM
Unknown Object (File)
Oct 13 2023, 4:33 PM
Unknown Object (File)
Oct 12 2023, 7:33 AM
View All 35 Files
Subscribers
andrew
emaste
• hselasky
imp
vishwin
linuxkpi

Details

Reviewers
kib
manu
• hselasky
Commits
rGdbb7cc419b49: Add missing file to sys/conf/files after…
rG8ca78eb03fd4: LinuxKPI: Make FPU sections thread-safe and use the NOCTX flag.
rG9340ebd404ef: Add missing file to sys/conf/files after…
rG792b602a337d: Bump the FreeBSD version after making FPU sections thread-safe in the LinuxKPI.
rG469884cf04a9: LinuxKPI: Make FPU sections thread-safe and use the NOCTX flag.
Summary

FPU_KERN_NOCTX should be enough to match the Linux semantics.

+ add explanation for the nesting counter.

Test Plan

Test with an AMD Navi GPU.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Apr 22 2021, 11:20 AM
Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptApr 22 2021, 11:20 AM
val_packett.cool requested review of this revision.Apr 22 2021, 11:20 AM
kib added inline comments.Apr 22 2021, 12:27 PM
sys/compat/linuxkpi/common/include/asm/fpu/api.h
36–37

This is still completely melts if more than one thread does kernel_fpu_begin()

36–37

Use ANSI C definitions.

36–37

Comment should follow style.

• hselasky added a subscriber: • hselasky.Apr 22 2021, 12:41 PM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/asm/fpu/api.h
36–37

Feel free to extend the LinuxKPI's "current" with this variable.

val_packett.cool updated this revision to Diff 87979.Apr 22 2021, 3:15 PM
val_packett.cool retitled this revision from linuxkpi: use NOCTX FPU sections to linuxkpi: make FPU sections thread-safe and NOCTX.
Herald added a subscriber: andrew. · View Herald TranscriptApr 22 2021, 3:15 PM
val_packett.cool added inline comments.Apr 22 2021, 3:19 PM
sys/compat/linuxkpi/common/include/asm/fpu/api.h
36–37

Feel free to extend the LinuxKPI's "current" with this variable.

OH! Thanks, that makes sense now. Where was this comment when I posted the original patch ;)

36–37

Huh? The only non-ANSI thing I know of is "K&R style" local variables being declared before the opening { bracket. But these functions do not declare any locals at all…??

val_packett.cool added inline comments.Apr 22 2021, 3:20 PM
sys/compat/linuxkpi/common/include/asm/fpu/api.h
36–37

Oh.. you mean the whole "blank () args doesn't mean no args" thing I guess

val_packett.cool updated this revision to Diff 87983.Apr 22 2021, 3:45 PM
kib accepted this revision.Apr 22 2021, 5:00 PM
This revision is now accepted and ready to land.Apr 22 2021, 5:00 PM
val_packett.cool added a comment.Jul 30 2021, 1:13 PM

No one is stepping up to test on affected hardware, so I guess this can just be committed already

• hselasky accepted this revision.Jul 30 2021, 1:16 PM

Make sure you bump the __FreeBSD_version when you commit this.

--HPS

val_packett.cool added a comment.Jul 30 2021, 1:57 PM

well, I can't exactly commit anything myself ;)

• hselasky added a comment.Jul 30 2021, 3:16 PM

I'll try to help you. Just be patient :-)

Closed by commit rG469884cf04a9: LinuxKPI: Make FPU sections thread-safe and use the NOCTX flag. (authored by • hselasky). · Explain WhyJul 31 2021, 1:38 PM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG469884cf04a9: LinuxKPI: Make FPU sections thread-safe and use the NOCTX flag..
• hselasky added a commit: rG792b602a337d: Bump the FreeBSD version after making FPU sections thread-safe in the LinuxKPI..Jul 31 2021, 1:41 PM
vishwin added a subscriber: vishwin.Aug 1 2021, 2:37 PM

This broke at least i915kms from drm-kmod despite building successfully. I've reported there as well, since I'm not sure where any fixes need to go.

• hselasky added a commit: rG9340ebd404ef: Add missing file to sys/conf/files after….Aug 2 2021, 6:26 AM
• hselasky added a comment.Aug 2 2021, 6:27 AM

Should be fixed now.

jhb added a commit: rG8ca78eb03fd4: LinuxKPI: Make FPU sections thread-safe and use the NOCTX flag..Mar 22 2023, 4:33 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 22 2023, 4:33 PM
jhb added a commit: rGdbb7cc419b49: Add missing file to sys/conf/files after….Mar 22 2023, 4:33 PM
jhb added a reverting change: rGfa6603d4a725: Revert "LinuxKPI: Make FPU sections thread-safe and use the NOCTX flag.".May 27 2023, 7:34 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
asm/
fpu/
40 lines
linux/
3 lines
src/
43 lines
conf/
3 lines
4 lines
3 lines
modules/
linuxkpi/
3 lines

Diff 93046

View Options

sys/compat/linuxkpi/common/include/asm/fpu/api.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/sched.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_fpu.c

Loading...
View Options

sys/conf/files.amd64

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/conf/files.i386

Loading...
View Options

sys/modules/linuxkpi/Makefile

Loading...