Page MenuHomeFreeBSD
Differential D56598

arm64: Add RSI detection for CCA
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Thu, Apr 23, 10:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 14, 3:57 AM
Unknown Object (File)
Wed, May 13, 9:32 PM
Unknown Object (File)
Wed, May 13, 1:10 AM
Unknown Object (File)
Tue, May 12, 9:27 AM
Unknown Object (File)
Mon, May 11, 11:44 AM
Unknown Object (File)
Mon, May 11, 4:23 AM
Unknown Object (File)
Mon, May 11, 1:58 AM
Unknown Object (File)
Sun, May 10, 9:59 AM
View All 31 Files
Subscribers
emaste
imp
olce

Details

Reviewers
andrew
manu
Commits
rG76a2904c352b: arm64: Add RSI detection for CCA
Summary

Detect the presence of the Realm Services Interface (RSI). This detection is
performed early in bootup; PSCI initialisation has been moved to initarm() to
faciliate this.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sarah.walker2_arm.com created this revision.Thu, Apr 23, 10:29 AM
Herald added a reviewer: andrew. · View Herald TranscriptThu, Apr 23, 10:29 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: olce, emaste, imp. · View Herald Transcript
sarah.walker2_arm.com requested review of this revision.Thu, Apr 23, 10:29 AM
Harbormaster completed remote builds in B72464: Diff 176243.Thu, Apr 23, 10:29 AM
sarah.walker2_arm.com added a child revision: D56599: arm64: VM/PMAP changes for CCA guest support.Thu, Apr 23, 10:30 AM
sarah.walker2_arm.com mentioned this in D56520: arm64: Add CCA guest support.Thu, Apr 23, 10:31 AM
andrew added inline comments.Thu, Apr 23, 4:12 PM
sys/arm64/arm64/rsi.c
45–53

Are these are needed?

sys/dev/psci/psci.h
49

This is defined on both arm and arm64

sarah.walker2_arm.com updated this revision to Diff 176273.Thu, Apr 23, 5:26 PM

Remove unnecessary #includes, remove unncessary aarch64 guard

Harbormaster completed remote builds in B72487: Diff 176273.Thu, Apr 23, 5:26 PM
andrew added a comment.Tue, May 5, 2:00 PM

Just style

sys/arm64/arm64/rsi.c
51–52

And again below

56

I think this can use arm_smccc_invoke_smc to remove the 0 arguments

58–61
sarah.walker2_arm.com updated this revision to Diff 177315.Wed, May 6, 4:17 PM

Address review comments.

Harbormaster completed remote builds in B72855: Diff 177315.Wed, May 6, 4:17 PM
andrew accepted this revision.Fri, May 8, 2:51 PM
This revision is now accepted and ready to land.Fri, May 8, 2:51 PM
Closed by commit rG76a2904c352b: arm64: Add RSI detection for CCA (authored by sarah.walker2_arm.com, committed by andrew). · Explain WhyTue, May 12, 4:56 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG76a2904c352b: arm64: Add RSI detection for CCA.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
5 lines
2 lines
185 lines
include/
3 lines
129 lines
conf/
1 line
dev/
psci/
3 lines
11 lines

Diff 177689

View Options

sys/arm64/arm64/machdep.c

Loading...
View Options

sys/arm64/arm64/pmap.c

Loading...
View Options

sys/arm64/arm64/rsi.c

Loading...
View Options

sys/arm64/include/pmap.h

Loading...
View Options

sys/arm64/include/rsi.h

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/dev/psci/psci.h

Loading...
View Options

sys/dev/psci/psci.c

Loading...