Page MenuHomeFreeBSD
Differential D30598

xen/intr: merge parts of resume functionality into new function
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Jun 1 2021, 3:43 PM.
Tags
None
Referenced Files
F164135189: D30598.id91726.diff
Wed, Jul 29, 1:33 AM
Unknown Object (File)
Mon, Jul 27, 4:48 AM
Unknown Object (File)
Sat, Jul 25, 7:36 PM
Unknown Object (File)
Sat, Jul 25, 6:27 AM
Unknown Object (File)
Thu, Jul 23, 10:43 PM
Unknown Object (File)
Thu, Jul 23, 11:01 AM
Unknown Object (File)
Wed, Jul 22, 11:34 AM
Unknown Object (File)
Wed, Jul 22, 9:32 AM
View All Files
Subscribers
imp

Details

Reviewers
royger
mhorne
julien_xen.org
Commits
rGe45c8ea31cd8: xen/intr: merge parts of resume functionality into new function
Summary

The portions of xen_rebind_ipi() and xen_rebind_virq() were already
near-identical. While xen_rebind_ipi() should panic() on
single-processor, still having the functionality to invoke seems
harmless.

Meanwhile much of the loop from xen_intr_resume() seemed to want to be
closer to this same code. This pushes related bits closer together.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39644
Build 36533: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Jun 1 2021, 3:43 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 1 2021, 3:43 PM
ehem_freebsd_m5p.com requested review of this revision.Jun 1 2021, 3:43 PM
Harbormaster completed remote builds in B39644: Diff 90270.Jun 1 2021, 3:43 PM
ehem_freebsd_m5p.com added a parent revision: D30236: xen/intr: move sys/x86/xen/xen_intr.c to sys/xen/xen_intr.c.Jun 1 2021, 3:47 PM
ehem_freebsd_m5p.com added a child revision: D30599: xen/intr: rework xen_intr_resume() for in-place remapping.
ehem_freebsd_m5p.com mentioned this in D30599: xen/intr: rework xen_intr_resume() for in-place remapping.Jun 1 2021, 3:55 PM
ehem_freebsd_m5p.com mentioned this in D30600: xen/intr: disable xen_intr_suspend() and xen_intr_resume() on !x86.Jun 1 2021, 3:57 PM
ehem_freebsd_m5p.com updated this revision to Diff 91150.Jun 21 2021, 2:30 AM

Fixing a bug which was found while glancing at this delta.

Harbormaster completed remote builds in B40007: Diff 91150.Jun 21 2021, 2:30 AM
ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 1:28 AM
ehem_freebsd_m5p.com removed a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 2:25 AM
ehem_freebsd_m5p.com removed a parent revision: D30236: xen/intr: move sys/x86/xen/xen_intr.c to sys/xen/xen_intr.c.Jul 1 2021, 1:59 AM
ehem_freebsd_m5p.com updated this revision to Diff 91726.Jul 4 2021, 10:12 PM

Removing one line which really should have been removed before.

Harbormaster completed remote builds in B40265: Diff 91726.Jul 4 2021, 10:12 PM
ehem_freebsd_m5p.com updated this revision to Diff 91727.Jul 4 2021, 10:20 PM

Move the isrc->xi_cpu = 0; line lower, hopefully hinting this is part of the xen_intr_assign_cpu() call.

Harbormaster completed remote builds in B40266: Diff 91727.Jul 4 2021, 10:20 PM
ehem_freebsd_m5p.com updated this revision to Diff 92708.Jul 24 2021, 3:49 PM

Small update, keep panic strings closer to original, but add function name. Should make diagnosis easier if this ever gets triggered.

Harbormaster completed remote builds in B40662: Diff 92708.Jul 24 2021, 3:50 PM
ehem_freebsd_m5p.com updated this revision to Diff 92840.Jul 28 2021, 6:17 AM

Fix a potential unused variable warning. Single-processor systems almost seem archaic, but we should still function on such.

Harbormaster completed remote builds in B40705: Diff 92840.Jul 28 2021, 6:17 AM
ehem_freebsd_m5p.com updated this revision to Diff 92841.Jul 28 2021, 6:29 AM

Remove a bit more unused in case of uniprocessor code from uniprocessor builds. Such are actually rather more sensible in case of virtual machines...

Harbormaster completed remote builds in B40706: Diff 92841.Jul 28 2021, 6:29 AM
ehem_freebsd_m5p.com updated this revision to Diff 92842.Jul 28 2021, 6:38 AM

Ugh! Hopefully finish the hunt for bits which disappear if uniprocessor.

Harbormaster completed remote builds in B40707: Diff 92842.Jul 28 2021, 6:38 AM
ehem_freebsd_m5p.com updated this revision to Diff 93089.Aug 1 2021, 10:22 PM

Fixing issue discovered during review. The blanket wipe of ->xi_port in xen_intr_resume() can't be removed until D30599.

Harbormaster completed remote builds in B40794: Diff 93089.Aug 1 2021, 10:22 PM
ehem_freebsd_m5p.com added a parent revision: D30743: xen/intr: rework handling of event channel numbers in xen_intr.c.Sep 6 2021, 1:03 AM
ehem_freebsd_m5p.com added a comment.Sep 6 2021, 1:10 AM

I'm wondering if I should merge D30599 into D30598. D30598 is simply a precursor to implementing D30599.

ehem_freebsd_m5p.com mentioned this in D32789: xen/intr: mark several pieces unsigned.Nov 1 2021, 8:26 PM
ehem_freebsd_m5p.com updated this revision to Diff 97998.Nov 4 2021, 2:08 AM

Another signed/unsigned update, sorry.

Harbormaster completed remote builds in B42577: Diff 97998.Nov 4 2021, 2:08 AM
ehem_freebsd_m5p.com updated this revision to Diff 98048.Nov 5 2021, 5:24 AM

Another small update for the sign auditing.

Harbormaster completed remote builds in B42600: Diff 98048.Nov 5 2021, 5:24 AM
ehem_freebsd_m5p.com added inline comments.Nov 6 2021, 1:53 AM
sys/x86/xen/xen_intr.c
748–749 ↗(On Diff #98048)

Based on what I saw in D32866, I suspect there should be a intr_event_bind() here.

ehem_freebsd_m5p.com mentioned this in D30743: xen/intr: rework handling of event channel numbers in xen_intr.c.Nov 26 2021, 5:36 AM
ehem_freebsd_m5p.com updated this revision to Diff 99098.Nov 28 2021, 3:30 PM

Updating to ensure consistency with what I've got. Should still apply, but updates on D30743 have made application unclean.

Harbormaster completed remote builds in B43001: Diff 99098.Nov 28 2021, 3:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2023, 7:55 AM
Closed by commit rGe45c8ea31cd8: xen/intr: merge parts of resume functionality into new function (authored by ehem_freebsd_m5p.com, committed by royger). · Explain Why
This revision was automatically updated to reflect the committed changes.
royger added a commit: rGe45c8ea31cd8: xen/intr: merge parts of resume functionality into new function.

Revision Contents
Changeset List

PathSize
sys/
xen/
51 lines

Diff 90270

View Options

sys/xen/xen_intr.c

Loading...