Page MenuHomeFreeBSD
Differential D27974

Remove the MK_LIBCPLUSPLUS/MK_GNUCXX options
ClosedPublic
Actions

Authored by arichardson on Jan 5 2021, 12:23 PM.
Tags
None
Referenced Files
F84181575: D27974.id.diff
Mon, May 20, 12:17 PM
F84181484: D27974.id83153.diff
Mon, May 20, 12:15 PM
F84181481: D27974.id81812.diff
Mon, May 20, 12:15 PM
Unknown Object (File)
Fri, May 17, 1:51 PM
Unknown Object (File)
Mon, May 13, 11:15 AM
Unknown Object (File)
Mon, May 13, 8:11 AM
Unknown Object (File)
Mon, May 13, 8:10 AM
Unknown Object (File)
Mon, May 13, 5:13 AM
View All 76 Files
Subscribers
bdrewery
imp

Details

Reviewers
emaste
dim
Group Reviewers
manpages
Commits
rG3eb107dd5913: Remove the MK_LIBCPLUSPLUS option
rG5cf6f1c4bc28: Remove the MK_LIBCPLUSPLUS option
Summary

MK_GNUCXX was removed together with GCC 4.2.1 (20200229), but there were
still some remains of this option in the build system.
This commit also removes the MK_LIBCPLUSPLUS option (since this is now
equivalent to any form of C++ support) and changes all uses to MK_CXX.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35993
Build 32882: arc lint + arc unit

Event Timeline

arichardson created this revision.Jan 5 2021, 12:23 PM
Herald added a reviewer: manpages. · View Herald TranscriptJan 5 2021, 12:23 PM
Herald added subscribers: imp, bdrewery. · View Herald Transcript
arichardson requested review of this revision.Jan 5 2021, 12:23 PM
Harbormaster completed remote builds in B35946: Diff 81671.Jan 5 2021, 12:23 PM
emaste added inline comments.Jan 7 2021, 3:59 PM
lib/libproc/Makefile
19

I don't understand this change

arichardson updated this revision to Diff 81811.Jan 7 2021, 4:05 PM

fix incorrect change

arichardson marked an inline comment as done.Jan 7 2021, 4:05 PM
arichardson added inline comments.
lib/libproc/Makefile
19

Oh yeah that is wrong.

Harbormaster completed remote builds in B35993: Diff 81811.Jan 7 2021, 4:05 PM
arichardson updated this revision to Diff 81812.Jan 7 2021, 4:11 PM
arichardson marked an inline comment as done.
  • bring back change to src.conf.5 that I accidentally reverted in last update
Harbormaster completed remote builds in B35994: Diff 81812.Jan 7 2021, 4:11 PM
arichardson updated this revision to Diff 81813.Jan 7 2021, 4:19 PM

rebase

Harbormaster completed remote builds in B35995: Diff 81813.Jan 7 2021, 4:19 PM
emaste added a comment.Jan 17 2021, 1:09 AM

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252759

arichardson updated this revision to Diff 83153.Jan 30 2021, 5:30 PM

rebase after LIBTHR

Harbormaster completed remote builds in B36625: Diff 83153.Jan 30 2021, 5:30 PM
emaste accepted this revision.Jan 30 2021, 5:48 PM
This revision is now accepted and ready to land.Jan 30 2021, 5:48 PM
emaste mentioned this in rG69557375226a: Remove unused GNUCXX option descriptions.Jan 30 2021, 5:48 PM
Closed by commit rG5cf6f1c4bc28: Remove the MK_LIBCPLUSPLUS option (authored by arichardson). · Explain WhyFeb 1 2021, 10:08 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG5cf6f1c4bc28: Remove the MK_LIBCPLUSPLUS option.
emaste mentioned this in rGe12d36cfabd2: Remove unused GNUCXX option descriptions.Feb 9 2022, 5:40 PM
jhb added a commit: rG3eb107dd5913: Remove the MK_LIBCPLUSPLUS option.Mar 22 2023, 4:33 PM

Revision Contents
Changeset List

Diff 81811

View Options

Makefile.inc1

Loading...
View Options

lib/Makefile

Loading...
View Options

lib/libproc/Makefile

Loading...
View Options

share/mk/bsd.libnames.mk

Loading...
View Options

share/mk/bsd.prog.mk

Loading...
View Options

share/mk/src.libnames.mk

Loading...
View Options

share/mk/src.opts.mk

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...
View Options

tools/build/options/WITHOUT_GNUCXX

Loading...
View Options

tools/build/options/WITHOUT_LIBCPLUSPLUS

Loading...
View Options

tools/build/options/WITH_GNUCXX

Loading...
View Options

tools/build/options/WITH_LIBCPLUSPLUS

Loading...