Page MenuHomeFreeBSD
Differential D56034

tunefs: Add tests
ClosedPublic
Actions

Authored by des on Mar 22 2026, 6:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 3:35 AM
Unknown Object (File)
Mon, May 18, 3:27 AM
Unknown Object (File)
Sun, May 17, 3:45 PM
Unknown Object (File)
Sun, May 17, 3:16 PM
Unknown Object (File)
Sun, May 17, 4:32 AM
Unknown Object (File)
Wed, May 13, 7:41 PM
Unknown Object (File)
Tue, May 12, 1:44 AM
Unknown Object (File)
Tue, May 12, 1:44 AM
View All 38 Files
Subscribers
imp
ivy
ngie

Details

Reviewers
ngie
Group Reviewers
tests
Commits
rG83ec9a97e19d: tunefs: Add tests
rGb78e2b69893c: tunefs: Add tests
rG6630c3a73688: tunefs: Add tests
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71646
Build 68529: arc lint + arc unit

Event Timeline

des created this revision.Mar 22 2026, 6:59 PM
Herald added subscribers: ivy, imp. · View Herald TranscriptMar 22 2026, 6:59 PM
des requested review of this revision.Mar 22 2026, 6:59 PM
Harbormaster completed remote builds in B71646: Diff 174132.Mar 22 2026, 6:59 PM
des added a parent revision: D56033: tunefs: Don't lower WARNS.Mar 22 2026, 6:59 PM
des added a reviewer: tests.Mar 22 2026, 7:00 PM
des added a parent revision: D56010: file: Parse some UFS2 flags.Mar 22 2026, 7:03 PM
ngie accepted this revision.Mar 24 2026, 4:24 PM
ngie added a subscriber: ngie.
ngie added inline comments.
sbin/tunefs/tests/tunefs_test.sh
15–50

Most of my recommendations are to just make the function a bit easier for humans to follow and for the function to be easier to maintain in the future.

95–185

I think you could use su instead of sunoj for brevity.

This revision is now accepted and ready to land.Mar 24 2026, 4:24 PM
Closed by commit rG6630c3a73688: tunefs: Add tests (authored by des). · Explain WhyApr 2 2026, 11:22 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG6630c3a73688: tunefs: Add tests.
des added a commit: rGb78e2b69893c: tunefs: Add tests.Apr 4 2026, 9:00 AM
des added a commit: rG83ec9a97e19d: tunefs: Add tests.

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
sbin/
tunefs/
5 lines
tests/
4 lines
189 lines

Diff 174132

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

sbin/tunefs/Makefile

Loading...
View Options

sbin/tunefs/tests/Makefile

Loading...
View Options

sbin/tunefs/tests/tunefs_test.sh

Loading...