Differential D48735
acpi: Call SPMC suspend/resume hooks Authored by obiwac on Jan 30 2025, 7:07 PM. Project Tags None Referenced Files
Details Calls SPMC suspend method if an acpi_spmc device exists before going to sleep but after having already suspended all devices, and call the SPMC resume method after we've woken up but before resuming all devices. This adds a new ACPI_PMC interface, which can be used by PMCs (power management controllers) for late suspend or early resume. See D48387. Framework 13 AMD Ryzen 7040 series enters a standby mode (power button led fades in and out slowly).
Diff Detail
Event TimelineComment Actions Suspend works on my Lenovo notebook. After resume there is no response to pressing keyboard keys in the console, but switching between terminals works. Comment Actions Awesome! I'll start work on reading residency counters on Intel (though the LPIT) soon, so we can check if the CPU is actually entering S0i3 on Intel :) As per your keyboard issue, since switching between terminals works, I'm assuming this is not per se a driver issue - I guess this needs more work to debug. Does the keyboard still work after resuming in an X or Wayland session? Comment Actions I tested it without X session and i915kms loaded because screen remains black in an X session after resume. Comment Actions
Not sure if it will be related but I have seen issues with modifier key status becoming incorrect. When the keyboard is not functional can you try pressing and releasing each of the Shift, Ctrl, and Alt keys in turn, and see if it works after that? Comment Actions See changes/comments in D48387, but will add an interface for PMC suspend and resume which this will use. Comment Actions Add acpi_pmc interface, which acpi_EnterSleepState() calls the suspend and resume methods of during late suspend and early resume. Comment Actions Rename acpi_pmc_suspend/acpi_pmc_resume to acpi_late_suspend/acpi_early_resume respectively (at request of olce@).
| ||||||||||||||||||||||||||||||||