Sponsored by: The FreeBSD Foundation
Details
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 69679 Build 66562: arc lint + arc unit
Event Timeline
Are you speaking about the files here[1]?
If the answer is yes, this is a mistake, doceng@ forgot to remove this files when they removed the languages.
[1] https://cgit.freebsd.org/doc/tree/website/themes/beastie/i18n
@mark_freebsdfoundation.org can you please upload the current changes to the server? Thanks!
- Yes, I know, the current website works like this: https://www.freebsd.org/projects/newbies/, the link points to the same page, so seems that nothing happens. We can fix this, but complicates the code to much, I think is better to keep it like this
- Russian fixed, about Chinese, zh-cn or zh-tw, or both?
- Done, I added a dropdown menu, I think I will use the same approach for the documentation portal
- Fixed with the point 3
About all of these, please wait for Mark to upload the new changes.
I noticed the language picker was broken @carlavilla - similar story to other menu items, it was hard coded to 'www.freebsd.org' thus doesn't work on the test site. This PR fixes itβ¦ https://github.com/sergio-carlavilla/freebsd-new-design/pull/22 π
I currently have no idea why @carlavilla β but if you change to another language besides English, then click back to English, /en on the test site will redirect back to www.freebsd.org. I'm not sure where it's picking this up from, because the URL is server relative (i.e. freebsd.fortasse.cloud/en) β do you know what's happening here?
Thanks!
Hey @carlavilla π Once @dbaio has confirmed Hugo upgrade, let's drop what you have? If it can't be loaded into this review, shall we make a new one and point to this as the history? It would be great to get it live though! π
@carlavilla PR for the deprecation warning fixes π https://github.com/sergio-carlavilla/freebsd-new-design/pull/24
Please understand that I am personally committed to seeing this website refresh land, however I am formally requesting changes proposed over email. I would like to propose the line objected to is replaced with "For over 30 years, this has been a grass roots project carried by passionate volunteers."
(please note that the webui selected to request changes based on all the teams that I am in. This was an unintentional and I am requesting changes purely on the grounds of myself)
I cannot upload the diff using the web interface :'(
@mark_freebsdfoundation.org can you upload the current changes to your website?
For me, the only thing left is the header menu in Russian and maybe improve the download sections in the main page.
I'll try to finish these two things this night
Firstly, for those of us not privy to this private email chain, what specifically is being objected to, and why?
Secondly, I don't like this proposal. FreeBSD is where it is today because of volunteers, but it is also where it is today because of the many corporate and research entities who employ people whose jobs include improving FreeBSD. I think it also just makes the project sound unprofessional in nature.
The line "Check out the engagement driven by the FreeBSD Foundation on YouTube" is being objected to on the grounds that it is inappropriate for the "Community" box.
Secondly, I don't like this proposal. FreeBSD is where it is today because of volunteers, but it is also where it is today because of the many corporate and research entities who employ people whose jobs include improving FreeBSD. I think it also just makes the project sound unprofessional in nature.
Okay, thanks for engaging. I disagree that grass-roots volunteers is unprofessional, but do you have any alternative ideas?
What about "For over 30 years, this has been a grass-roots project driven by volunteers, research institutions, and corporate donations."? Alternatively, I and others in the email chain seemed to be fine with just removing the line and not adding anything.
A social media presence dedicated to FreeBSD, by people who are involved in FreeBSD, that is an official FreeBSD-related organisation, and is engaging with people on the internet, is inappropriate for the "Community" section of the FreeBSD website how?..
I changed the descriptions to make them a bit shorter, wait for Mark to upload it or check it in my repo please
The FreeBSD foundation is it's own entity, with it's own website. The Project is consists of a democratic system, which the Foundation exists completely separate and outside of.
Note that cloud companies sponsored some of our work, but I don't want to put that in the community box. The community box should be about the Project's community nature.
Except it's not really separate. They own the FreeBSD trademark. The FreeBSD website today has a whole Foundation tab in the navbar at the the top. And we have a big "Donate to FreeBSD" button in the top right that goes to the Foundation's site. So why is that all ok (which I believe it is, to be clear), but not acknowledging that they're also doing community outreach?
I'd disagree with that characterization if the foundation. It is very much a part of the community and has helped build parts of the community. It's very much not outside of the community.
I did not (nor did i mean to) say that it is not part of the community or has not helped build the community, or even me personally! Rather, the netflix freebsd community is a major part of the community and has helped build it a lot, should that be in the community box? Rather than a statement about the community as a whole?
This is a box labeled "Community" on the front page with 3 sentences. It shouldn't be advertising anything other than the Project's community.
That's a false analogy. Netflix hasn't done community building. FF is fundamentally different.
It hasn't? How much have you taught me while working under Netflix sponsorship? How many new contributors patches have been merged during your sponsored work? How many other companies are sponsoring developers for community outreach outside the narrow scope of exactly what they're working on?
Please understand, I am wearing a FreeBSD foundation shirt right now actually, but IMHO it's quite reasonable that the 3 sentences about community should be about the FreeBSD community as a whole, which should not be equated with just the Foundation.
@jrtc27 raises an important point here β and we need to think about these words more carefully. *Words matter*, and the current incarnation with _"For over 30 years, this has been a grass roots project carried by passionate volunteers"_ makes the project feel like a _hobby_ β which is precisely the argument large organisations are making for leaving FreeBSD as their base OS.
One must never forget FreeBSD is a critical choice in many other products, for reasons we can all discuss the various sides of, which don't matter right here, right now. What _does_ matter, however, is the whole point of this web refresh is to remind all those consumers that the OS we build is _not dying_. Because if all those companies that choose to use FreeBSD as their base dump it, and the donations stop, then it is just a hobby. And that would be a shame IMHO.
Another possibility might be "For over 30 years, this grassroots project has been powered by volunteers, research institutions, and corporate supporters."
Ok, I am going to change the sentence and for me that's it.
Later we need to improve the about page and also the downloads page, but that, in another review and as a next step, if not, we're going to be stuck here forever
Iβll sort the copy Sergio π
Going to try to rebase it again later. Then we should absolutely ship it and tune later π
Is this going to land soon? I'd really like to avoid colliding with 15.1 release engineering; I bump a lot of files when the release comes out and I don't want to deal with rebase conflicts at announcement time.
@carlavilla β ship it! π I've rebased on main and sorted the words on the community section.
The new icons look great! The new text for community is fine, but it doesn't mention research institutions. I noticed some technical things while giving it a final review.
| website/content/en/applications.adoc | ||
|---|---|---|
| 20 | I noticed you converted everything to link: (which is not really necessary btw, and would reduce the amount of files touched in this diff), but this one was converted to absoluteurl with no link: prefix. is there a reason for this? | |
| website/content/en/languages.adoc | ||
| 7 | why are you adding these files? I thought that the language key in hugo.toml covers this? | |
| website/themes/beastie/LICENSE | ||
| 2 β | (On Diff #177684) | please do not bump copyright backwards. this will also reduce the diff of files. |
| website/themes/beastie/layouts/_partials/site-head.html | ||
| 92 | this looks like a different analytics script than we were using earlier? Can we have some background on that for what is described as just "a fresh coat of paint?". | |
| website/themes/beastie/theme.toml | ||
| 6 β | (On Diff #177684) | Please revert this line, this is required for the language key modernization we did. |
Comments and fixes.
| website/content/en/applications.adoc | ||
|---|---|---|
| 20 | I can't comment on this, I merely sync'd up the files from @carlavilla GH. Maybe Sergio knows? | |
| website/content/en/languages.adoc | ||
| 7 | One for @carlavilla again. | |
| website/themes/beastie/LICENSE | ||
| 2 β | (On Diff #177684) | A victim of the sync. Fixed (will push with other fixes in a moment) |
| website/themes/beastie/layouts/_partials/site-head.html | ||
| 92 | Lose the snark, it's unecessary. "Challenge with good intent" please - don't assume nafariousness is afoot. Always assume good intent, and question with the idea of understanding. Plausible updated the way their script is consumed, that is all. | |
| website/themes/beastie/theme.toml | ||
| 6 β | (On Diff #177684) | It only ensures Hugo knows what version to work with, it breaks nothing, especially since we're now on 0.161 in production. However, it's fixed in the update I'm about to push. |
Sergio, please don't update your GH any longer, getting it in sync with this review was hard work π Whatever those last changes were, either apply them after this has gone live, or put them on this review please and thank you π
Sergio, please don't update your GH any longer, getting it in sync with this review was hard work π Whatever those last changes were, either apply them after this has gone live, or put them on this review please and thank you π
Never mind, it rsync'd OK @carlavilla
This review reflects what's in your GH now π
@carlavilla The width is too much now - I only ever get the burger menu on my laptop screen, even at max width.
yes, happened the same to me in my computer, the problem is with the Russian language only. Maybe @vladlen can help us and put a short texts
Putting briefly my core@ hat on I think we are ok for secteam & clusteradm, if there's anything catastrophically wrong we can of course just do tiny patches afterwards.
π Can we revert the width and get the help from @vladlen? It looks and feels clunky with the burger on a laptop screen.
| website/themes/beastie/layouts/_partials/site-head.html | ||
|---|---|---|
| 92 | Can you loose the assumption of bad intent? Commit messages needs to say what is changing so people can maintain the doc. In this example, we have doc that says that we ripped out Google Analytics but does not mention that we use Plausible Analytics. That is something I should be able to read the commit messages and fix. I'd like to point out that I am the only committer who has been consistently pushing for this since it was started. I have sent more emails and more pings asking people to review and get this moving. The patronizing berating leaves lasting damage to our reputations. | |
alright. i tried building this with DOC_LANG= , public/index.html is illegible, public/en/index.html redirects to actual f.o, and make run gives a site with no header buttons except the hambuger menu.
this is normal, don't worry about it.
@mark_freebsdfoundation.org I restored the old width. I will try to make a real fix this night. Btw, I'll commit it on Friday.
I see the problem: Russian words in the menu are long, making the menu very wide. I have not yet found a good replacement β abbreviated versions of the menu items look rude or like slang. I would also say that the English descriptions are quite long as well, and currently the menu switches to smartphone mode at a width of 1350β―px, whereas the recommended breakpoint for smartphones is 767β―px.
I have a proposal. When the screen becomes smaller, the angle symbols in the menu wrap to a new line, and the menu looks strange. Could we remove these angles (I mean the HTML elements <i class="fa fa-angle-down fa-lg" aria-hidden="true"></i>)? The menu items look quite visible without these elements. As a result, the screen width can be decreased down to 767β―px (smartphone size), and both English and Russian texts look good β for example, "Get FreeBSD" in both languages splits into two lines and looks good. In this case we could use:
@media screen and (max-width: 768px)
Star! Thanks Sergio. Iβll bring the change in to this and push to the test site. Give me 10 minutes please π
Just as a general observation - and don't block landing this, but do fix this later - you can't assume that your text is going to pretty fit your widgets. This is not only for language reasons but for accessibility reasons.
Plenty of people I know will jack the font size /way/ up on desktop, tablet and phone screens.
So don't block landing on making this work, but someone's going to need to address that.
(Also, you shouldn't be making text fit specific pixel size elements, but that's again a later problem to solve and I won't block getting this landed.)
Thanks!
em/rem FTW π
I think there are a few things we can tidy up post-land. For now this all does its intended job - i.e. let's people find out about, download, and learn FreeBSD. With a more modern view through the metaphorical shop window.
Over the last few months there have been some really good usability comments from lots of folks, not least @jrtc27, @grahamperrin and @vladlen. I'd love to go back over those once live and address in small edits. This, as it now stands, is to my eyes a 'minimal lovable product'. It's a great piece of work. Let's ship it @carlavilla ! π
The new diff fixes the problems rendered in make run. Approving as myself, releng based on the discussion with @dch and @cperciva, and approving as doceng based on myself and feedback timeout. @dch on behalf of Core Team said earlier that this is fine with secteam, clusteradm said it was fine over email, #translations said no objection earlier. Afaict, we have successfully got someone from each team to sign off on it, and we can now merge this with consensus.
@carlavilla, IIUC I believe this should be committed with Mark McBride as the principal author, co-authored by you and @mark_freebsdfoundation.org, and reviewed by the appropriate teammates, and discussed with the teammates who contributed to this patch with suggestions but did not formally approve or request changes.
Let's get this in, and then I look forward to @vladlen's translation logic rewrite he proposed on GitHub. This has truly been an epic journey, tensions were high, lots of different parties coming in and quite a few even resigning. Separately from the technical improvement, I think we pulled through as team and made it happen for the Project, with many difficult compromises, and that really matters.
Ok, I don't care about the "authority", basically coz "the starts in your github is not going to pay the bills"
About the open PR I have in my personal repo, I think is not a good approach, one thing is the theme, and the other is the content of the website. With this approach we are going to mix it together.
And I know we made this in the documentation in some places, but it's not ok, that comes from the time I migrated from Docbook to Hugo
BTW, we should fix this after the merge, but I noticed there is no link to freebsd.org/where in the header on the mobile version of the page. The drop down menu just clicks back closed.
In D53910#1305694, @ziaee wrote:
β¦ quite a few even resigning. β¦
I see just one:
- https://reviews.freebsd.org/D53910/new/#1241872
- find then click Show Older Changes (repeatedly) β¦
I really don't want to focus on that part of this, but, yeah, even the original author resigned.
