vtnet: fix enabling/disabling tso
ClosedPublic
Actions

Authored by tuexen on Thu, Nov 6, 11:11 PM.

Details

Reviewers

timo.voelker_fh-muenster.de
peter.lei_ieee.org
bryanv
kp

Commits

rGc50312b774e1: vtnet: fix enabling/disabling tso
rG0fb0ba51d8bc: vtnet: fix enabling/disabling tso
rG52df18d91b83: vtnet: fix enabling/disabling tso
rG4c50ac68166c: vtnet: fix enabling/disabling tso

Summary

Transmit segment offloading depends on transmit checksum offloading. Enforce that constraint.
This also fixes a bug, since if_hwassist bits are from the CSUM_ space, not from the IFCAP_ space.
This fixes PR 290773.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Thu, Nov 6, 11:11 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Nov 6, 11:11 PM

tuexen requested review of this revision.Thu, Nov 6, 11:11 PM

tuexen abandoned this revision.Thu, Nov 6, 11:37 PM

tuexen updated this revision to Diff 166005.Thu, Nov 6, 11:40 PM

tuexen retitled this revision from vtnet: fix enabling tso to vtnet: fix enabling/disabling tso.

tuexen edited the summary of this revision. (Show Details)

tuexen edited the summary of this revision. (Show Details)Thu, Nov 6, 11:43 PM

tuexen added reviewers: bryanv, kp.

tuexen edited the summary of this revision. (Show Details)

Use the correct sequence sequence of check and action.

tuexen edited the summary of this revision. (Show Details)Fri, Nov 7, 3:31 PM

emaste added a subscriber: emaste.Fri, Nov 7, 11:37 PM

Enabling TSO without TXCSUM is not good and should not be possible.

I added an inline comment to a line with an if. Other than that, there is nothing I would change.

sys/dev/virtio/network/if_vtnet.c
1372	Why do you explicitly check for `!= 0` here and below? This shorter form seems to check the same: `if (if_getcapenable(ifp) & (IFCAP_TXCSUM \| IFCAP_TSO4)) {`

This revision is now accepted and ready to land.Mon, Nov 10, 10:24 AM

Closed by commit rG4c50ac68166c: vtnet: fix enabling/disabling tso (authored by tuexen). · Explain WhyMon, Nov 10, 3:41 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG4c50ac68166c: vtnet: fix enabling/disabling tso.

tuexen marked an inline comment as done.Mon, Nov 10, 3:43 PM

tuexen added inline comments.

sys/dev/virtio/network/if_vtnet.c
1372	Why do you explicitly check for `!= 0` here and below? This shorter form seems to check the same: `if (if_getcapenable(ifp) & (IFCAP_TXCSUM \| IFCAP_TSO4)) {` The newer version would be `!= 0`, but this files uses it without a lot. So stay consistent. Also combine the tests, since this is shorter. Thanks for suggested the changes, used them in the committed version.