bridge: Divorce ifuntagged from vlanfilter
ClosedPublic
Actions

Authored by ivy on Wed, Aug 6, 1:43 PM.

Details

Reviewers

None

Group Reviewers

bridge
network

Commits

rG43ac5806a5a3: bridge: Divorce ifuntagged from vlanfilter

Summary

The ifuntagged option was added as part of the VLAN filtering feature,
but it's useful on its own to be able to place interface traffic in a
VLAN without having to configure every interface for VLAN filtering.

Always do the pvid processing in bridge even if IFBRF_VLANFILTER isn't
enabled, and don't prohibit configuring it.

Add a test for the specific case of setting untagged without vlanfilter.

This has no effect on bridges which don't have at least one interface
configured with ifuntagged.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66016
Build 62899: arc lint + arc unit

Event Timeline

ivy created this revision.Wed, Aug 6, 1:43 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptWed, Aug 6, 1:43 PM

ivy requested review of this revision.Wed, Aug 6, 1:43 PM

Harbormaster completed remote builds in B66016: Diff 159859.Wed, Aug 6, 1:43 PM

ivy mentioned this in D51185: bridge.4: Improve VLAN documentation.Wed, Aug 6, 4:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Aug 10, 3:38 PM

Closed by commit rG43ac5806a5a3: bridge: Divorce ifuntagged from vlanfilter (authored by ivy). · Explain Why

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG43ac5806a5a3: bridge: Divorce ifuntagged from vlanfilter.

Revision Contents
Changeset List

Path

Size

sys/

net/

if_bridge.c

28 lines

tests/

sys/

net/

if_bridge_test.sh

54 lines

Diff 159859

View Options

sys/net/if_bridge.c