Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 62604 Build 59488: arc lint + arc unit
Event Timeline
Comment Actions
The _1 and _2 parameter names are not typical in FreeBSD. I would suggest sticking with void *arg for the first argument and int flags for the second argument.
sys/ufs/ufs/ufs_dirhash.c | ||
---|---|---|
101 |
Comment Actions
IMHO, better to use meaningful names for arguments even though they aren't used:
foo_lowmem(void *ctx __unused, int flags __unused)
Comment Actions
Well, worse than argument arg is only variable var :) But since John suggested that, let it be so.
Comment Actions
Heh, ctx would be ok as well. void *arg is a pretty common idiom in FreeBSD for callback arguments where the entity registering a callback gets to pass through an opaque argument to the callback (which is what the first arguments to event handlers are).