Page MenuHomeFreeBSD

vm_lowmem: fix signature mismatch for lowmem event dispatcher
AcceptedPublic

Authored by aokblast on Sun, Feb 23, 5:14 PM.
Tags
None
Referenced Files
F110959423: D49111.id.diff
Tue, Feb 25, 11:16 AM
Unknown Object (File)
Tue, Feb 25, 6:14 AM
Unknown Object (File)
Tue, Feb 25, 12:25 AM
Unknown Object (File)
Tue, Feb 25, 12:19 AM
Unknown Object (File)
Mon, Feb 24, 8:29 PM
Unknown Object (File)
Mon, Feb 24, 8:02 PM
Unknown Object (File)
Mon, Feb 24, 3:51 PM

Details

Reviewers
rrs
jhb
glebius
Group Reviewers
transport

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 62604
Build 59488: arc lint + arc unit

Event Timeline

Use wrapper instead of overwrite

The _1 and _2 parameter names are not typical in FreeBSD. I would suggest sticking with void *arg for the first argument and int flags for the second argument.

sys/ufs/ufs/ufs_dirhash.c
101

IMHO, better to use meaningful names for arguments even though they aren't used:

foo_lowmem(void *ctx __unused, int flags __unused)

Fix naming convension for argument

This revision is now accepted and ready to land.Tue, Feb 25, 1:28 PM

Well, worse than argument arg is only variable var :) But since John suggested that, let it be so.

Heh, ctx would be ok as well. void *arg is a pretty common idiom in FreeBSD for callback arguments where the entity registering a callback gets to pass through an opaque argument to the callback (which is what the first arguments to event handlers are).