Differential D46596

pf: do not pass af to PFLOG_PACKET
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 5, 9:19 AM

	Unknown Object (File)
	Sun, Jul 5, 7:14 AM

	Unknown Object (File)
	Sat, Jul 4, 10:36 PM

	Unknown Object (File)
	Sat, Jul 4, 7:43 PM

	Unknown Object (File)
	Sat, Jul 4, 12:03 PM

	Unknown Object (File)
	Fri, Jul 3, 6:35 PM

	Unknown Object (File)
	Thu, Jul 2, 10:19 PM

	Unknown Object (File)
	Mon, Jun 22, 9:07 PM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGbc4b0defb012: pf: do not pass af to PFLOG_PACKET

Summary

Do not pass AF specific information to pf_test_rule() and PFLOG_PACKET()
because either the info is already available in struct pd or easy
to figure out. Makes pf_test() and pf_test6() even more similar
(with the target to remove one of them in the near future).
OK henning@

Obtained from: OpenBSD, claudio <claudio@openbsd.org>, 5480721ed1
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59384
Build 56271: arc lint + arc unit

Event Timeline

kp created this revision.Sep 7 2024, 9:37 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptSep 7 2024, 9:37 AM

kp requested review of this revision.Sep 7 2024, 9:37 AM

Harbormaster completed remote builds in B59384: Diff 143092.Sep 7 2024, 9:37 AM

kp added a parent revision: D46595: pf tests: ensure we don't NAT to link-local addresses.Sep 7 2024, 9:37 AM

kp added a child revision: D46597: pf: merge pf_scrub_ip() and pf_scrub_ip6().

Looks good to me.

This revision is now accepted and ready to land.Sep 14 2024, 8:24 AM

Closed by commit rGbc4b0defb012: pf: do not pass af to PFLOG_PACKET (authored by kp). · Explain WhySep 19 2024, 8:22 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGbc4b0defb012: pf: do not pass af to PFLOG_PACKET.

Revision Contents
Changeset List

Path

Size

sys/

net/

4 lines

2 lines

netpfil/

pf/

6 lines

20 lines

10 lines

Diff 143092

sys/net/if_pflog.h

Loading...

sys/net/pfvar.h

Loading...

sys/netpfil/pf/if_pflog.c

Loading...

sys/netpfil/pf/pf.c

Loading...

sys/netpfil/pf/pf_norm.c

Loading...